Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified parallelBabel API #54

Open
ef4 opened this issue Mar 7, 2019 · 1 comment
Open

Unified parallelBabel API #54

ef4 opened this issue Mar 7, 2019 · 1 comment
Labels

Comments

@ef4
Copy link
Contributor

ef4 commented Mar 7, 2019

Both broccoli-babel-transpiler and ember-cli-htmlbars-inline-precompile have invented their own mutually-incompatible solutions for plugin serialization.

broccoli-babel-transpiler allows a _parallelBabel key on any value within the plugin config, which will cause that value to get replaced based on its requireFile, buildWith, params, and/or useMethod properties. Everything but requireFile is optional.

ember-cli-htmlbars-inline-precompile allows a parallelBabel key on only the top-level values within the plugin config, which will cause that value to get replaced based on its requireFile, buildWith, and params, properties, which are all mandatory.

We're now stuck with these, but before this situation gets any worse I want to refactor both of them and embroider to share one library.

@NullVoxPopuli
Copy link
Collaborator

is this still an issue? we don't use ec-htmlbars-inline-precompile anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants