Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maybe have optimizeDeps come from embroider i.e. don't add @embroider/macros but we add it in our function #1621

Closed
mansona opened this issue Oct 3, 2023 · 1 comment · Fixed by #1623
Closed

maybe have optimizeDeps come from embroider i.e. don't add @embroider/macros but we add it in our function #1621

mansona opened this issue Oct 3, 2023 · 1 comment · Fixed by #1623
Assignees
@lolmaus

Comments

@mansona
Copy link
Member

mansona commented Oct 3, 2023 •
edited
Loading 

import { optimizeDeps } from '@embroider/vite'

...

optimizeDeps: optimizeDeps(),

And we should consider adding a way to add config that can merge, this might be a second phase

optimizeDeps: optimizeDeps({ something: true}),
@mansona mansona converted this from a draft issue Oct 3, 2023
@lolmaus lolmaus moved this from Todo to In Progress in Mainmatter Embroider Team Oct 3, 2023
@lolmaus
Copy link
Collaborator

lolmaus commented Oct 4, 2023

PR: #1623

@lolmaus lolmaus mentioned this issue Oct 4, 2023
Merged
@lolmaus lolmaus moved this from In Progress to Awaiting Review in Mainmatter Embroider Team Oct 5, 2023
@mansona mansona moved this from Awaiting Review to In Progress in Mainmatter Embroider Team Oct 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mainmatter Embroider Team Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolmaus lolmaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the optimizeDeps() helper lolmaus/embroider
2 participants
@lolmaus @mansona