Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@embroider/router ember-release job fails due to ember-auto-import v1 #1024

Closed
Windvis opened this issue Nov 18, 2021 · 0 comments · Fixed by #1027
Closed

@embroider/router ember-release job fails due to ember-auto-import v1 #1024

Windvis opened this issue Nov 18, 2021 · 0 comments · Fixed by #1027

Comments

@Windvis
Copy link
Collaborator

Windvis commented Nov 18, 2021

With the release of Ember 4 ember-auto-import v2 is now required. It seems that the @embroider/router addon still has v1 listed as a devDependency which means the "release" jobs fail in CI.

I think we can just bump the ember-auto-import dependency in that package without requiring v2 in consuming apps since it's a devDependency?

@Windvis Windvis changed the title @embroider/router ember-release fails due to ember-auto-import v1 usage @embroider/router ember-release job fails due to ember-auto-import v1 usage Nov 18, 2021
@Windvis Windvis changed the title @embroider/router ember-release job fails due to ember-auto-import v1 usage @embroider/router ember-release job fails due to ember-auto-import v1 Nov 18, 2021
@ef4 ef4 closed this as completed in #1027 Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant