From 10c6f7c22a38f0338376e3f19c1b37735c56b8f8 Mon Sep 17 00:00:00 2001
From: Robert Jackson <rjackson@linkedin.com>
Date: Wed, 9 Jun 2021 15:14:35 -0400
Subject: [PATCH] Run linting in CI before running the full matrix of jobs

---
 .github/workflows/ci.yml                  | 26 +++++++++++++++++++++--
 test-packages/support/suite-setup-util.ts |  7 ------
 2 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 086e0347c..ac46742a4 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -11,8 +11,30 @@ on:
     branches: [master]
 
 jobs:
+  linting:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - uses: actions/checkout@v1
+      - uses: volta-cli/action@v1
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+      - uses: actions/cache@v2
+        id: yarn-cache
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+      - run: yarn --frozen-lockfile
+      - name: lint
+        run: yarn lint
+
   discover_matrix:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     outputs:
       matrix: ${{ steps.set-matrix.outputs.matrix }}
     steps:
@@ -33,11 +55,11 @@ jobs:
         run: echo "::set-output name=matrix::$(node ./test-packages/support/suite-setup-util.js --matrix)"
 
   test:
-    needs: discover_matrix
+    needs: ["discover_matrix", "linting"]
     name: ${{ matrix.name }}
     runs-on: '${{ matrix.os }}-latest'
     timeout-minutes: 30
-    
+
     strategy:
       fail-fast: false
       matrix: ${{fromJson(needs.discover_matrix.outputs.matrix)}}
diff --git a/test-packages/support/suite-setup-util.ts b/test-packages/support/suite-setup-util.ts
index e0018ef9c..d8743ffe7 100644
--- a/test-packages/support/suite-setup-util.ts
+++ b/test-packages/support/suite-setup-util.ts
@@ -117,13 +117,6 @@ export async function githubMatrix() {
   });
 
   let include = [
-    // add our eslint
-    {
-      name: 'lint',
-      os: 'ubuntu',
-      command: 'yarn lint',
-      dir: resolve(__dirname, '..', '..'),
-    },
     ...suites.map(s => ({
       name: `${s.name} ubuntu`,
       os: 'ubuntu',