Improved layering between app and tests bundles #620
Conversation
mansona
force-pushed
the
improved-layering
branch
from
a727b4e to
a934952
Compare
|
@simonihmig and I pushed this forward and have passing tests. I published it as 2.7.3-alpha.0. @simonihmig is going to test it under real-app conditions before we merge. We think this is a minimum set of changes to fix the bug, but it leaves undone a lot of cleanup refactoring that could eliminate unused functionality in ember-auto-import and simplify the codebase. Essentially now we are trusting webpack to manage which deps get into app vs tests, so all the places where |
|
I tested this on our monorepo with many hundreds of (test-)apps and >150 instances of workarounds for failing tests due to this bug. After reverting those workarounds and running CI with the alpha release, >99% of apps were passing! The remaining failures were related to the more rare case when an app does not have any eai-handled imports, only the tests have. In that case there wouldn't be any app script, and with the previous implementation no chunks would be inserted into the index.html. This was fixed with 730270c, which I just pushed into this branch. 🎉 With that I have a perfectly green build now! 🎉 |
Fixes #503
Closes #512