added babel-plugin-ember-template-compilation #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candunaj
force-pushed
the
added-babel-plugin-ember-template-compilation
branch
from
d28d476 to
72b5850
Compare
|
Thanks this looks good. Please see lint failures in CI. |
candunaj
force-pushed
the
added-babel-plugin-ember-template-compilation
branch
from
72b5850 to
4567850
Compare
This was referenced Apr 3, 2023
|
Thanks. The ci failures for canary are unrelated and already fixed on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-auto-import is used for loading V2 addons. There is a bug, that babel-plugin-htmlbars-inline-precompile is always used. For newer versions of ember-source>=3.27.0 babel-plugin-ember-template-compilation should be used.
This PR can be the start of a discussion of how to solve it. If there is a suggestion on how to improve the solution, I would like to implement it.