Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5UnsignedLongAccessHack not working anymore? #57

Open
tischi opened this issue May 18, 2022 · 5 comments
Open

HDF5UnsignedLongAccessHack not working anymore? #57

tischi opened this issue May 18, 2022 · 5 comments
Labels
question Further information is requested

Comments

@tischi
Copy link
Collaborator

tischi commented May 18, 2022

...do we even still need this?

@tischi tischi added the question Further information is requested label May 18, 2022
@tischi
Copy link
Collaborator Author

tischi commented May 18, 2022

@constantinpape

Are we still needing this for MoBIE?
bdv.hdf5.ulong
This currently lives in imagej-utils, and I am not so sure this is currently still working, due to some jhdf5 dependency updates...
If we still use this, can I test it somewhere?

@tischi
Copy link
Collaborator Author

tischi commented May 18, 2022

Also, if this really is still needed, I would think this would make sense to move this to mobie-io instead.

@constantinpape
Copy link
Contributor

We would still need it to support segmentations in HDF5. We currently don't have a project that uses it (since we converted the platy data to n5).
I would suggest the following:

  • I create a test-project that would require it tomorrow morning.
  • If it's simple you can fix the issues with it.
  • Otherwise we move ahead without this to get out the MoBIE-beta release and revisit this at a later point.

@tischi
Copy link
Collaborator Author

tischi commented May 19, 2022

Thanks!
I am fighting with dependency issues, because I got confused which versions of Jhdf5 and Bdv are currently shipped with Fiji. It currently looks like I tried to be compatible with too new versions and may have to roll back the scijava parent pom in all our repositories:

  • mobie-io
  • mobie
  • imagej-utils

Waiting for confirmation and advice: https://gitter.im/fiji/fiji and https://gitter.im/bigdataviewer/bigdataviewer-core
Hoping to fix everything today.

@constantinpape
Copy link
Contributor

@tischi I created a test project that need the ulong support for hdf5 to work properly: /g/kreshuk/pape/Work/mobie/platy-hdf5-test
(It contains a segmentation called "cells" that will need it).

Like I said: it would be nice to still support it, but if this is keeping you from pushing out MoBIE-beta please go ahead without it and we can revisit this later; nothing we currently have "in production" is relying on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants