Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

RFC #523 - Tracking for @model named argument to route templates #56

Closed
6 of 7 tasks
locks opened this issue Sep 2, 2019 · 4 comments
Closed
6 of 7 tasks

RFC #523 - Tracking for @model named argument to route templates #56

locks opened this issue Sep 2, 2019 · 4 comments
Labels
needs planning:ember.js Needs planning by ember.js team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team

Comments

@locks
Copy link
Contributor

locks commented Sep 2, 2019

RFC #0523 - Tracking for @model named argument to route templates

Champion: @chancancode


Expand for Instructions

All teams need to consider a merged RFC to plan any required work. Each team should comment on or edit this with links to issues for the work (or a note to the effect of "No work required").

See the README for more information
See #3 for an example

Under each team, for each repo requiring work for the RFC under that team:
### [repo name](repo url)

- [ ] (issue or pr) description, (issue or pr) link

Remove Repos that do not apply, conversely, there will probably be other repos that need work and should be added.

Ember.js Team:

ember.js

  • Implement @model (PR)

Ember CLI Team:

ember-cli

Ember Data Team:

ember-data

Learning Team:

guides-source

  • References to this.model need to be updated
  • @model might need to be explained before component arguments?
  • update tutorial material
  • update source code for Learning-managed Ember application
  • make sure it doesn't break inspector
  • include in release post

Steering Committee:

N/A

@locks locks added needs planning:ember.js Needs planning by ember.js team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team needs planning:learning Needs planning by the learning team labels Sep 2, 2019
@kennethlarsen kennethlarsen removed the needs planning:learning Needs planning by the learning team label Sep 5, 2019
@locks
Copy link
Contributor Author

locks commented Apr 24, 2020

I am marking "update source code for Learning-managed Ember application" as done despite it being worded a bit fuzzily as to exactly which applications this refers to, because we have certain hard blockers on certains applications that are being addressed and wouldn't make sense to track in the context of this RFC.

@locks
Copy link
Contributor Author

locks commented Apr 24, 2020

Confirming the Ember Inspector item with the team. (cc @rwwagner90 ?)

@chancancode
Copy link
Member

Yep this works

@locks
Copy link
Contributor Author

locks commented Apr 25, 2020

Thank you!

@locks locks closed this as completed Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs planning:ember.js Needs planning by ember.js team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team
Projects
None yet
Development

No branches or pull requests

3 participants