Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling _super on a frozen object results in a violation of the freeze #5464

Closed
mixonic opened this issue Aug 21, 2014 · 4 comments
Closed

Comments

@mixonic
Copy link
Member

mixonic commented Aug 21, 2014

In 1.5, it was possible to:

var a = Ember.A([]);
var MyArrayMixin = Ember.Mixin.create({
  contains: function(){
    return this._super();
  }
});
MyArrayMixin.apply(a);
Object.freeze(a);
a.contains();

By 1.6, this raised an exception about modifying the frozen object. The exception is raised by __nextSuper, though __nextSuper was already in 1.5.

http://emberjs.jsbin.com/mixowa/1/edit?html,js,output

Replaces #5324 as a general case, could be addressed by #5430. May ref #5463.

@wagenet
Copy link
Member

wagenet commented Nov 1, 2014

Issue still exists in 1.8.0. @mixonic any updates?

@mixonic
Copy link
Member Author

mixonic commented Nov 2, 2014

not yet

@stefanpenner
Copy link
Member

We have removed the chances dramatically

@rwjblue
Copy link
Member

rwjblue commented Aug 23, 2015

@rwjblue rwjblue closed this as completed Aug 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants