Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] with ember-source 3.25.3: href empty from links in rendering tests #19451

Closed
esbanarango opened this issue Mar 8, 2021 · 2 comments
Closed

Comments

@esbanarango
Copy link
Contributor

🐞 Describe the Bug

In a rendering tests the href returned from the link helper is always empty.

🔬 Minimal Reproduction

  test('href test', async function (assert) {
    assert.expect(1);
    await render(hbs`
      {{#let (link route="login") as |l|}}
        <a href={{l.url}}>Login</a>
      {{/let}}
    `);
    assert.dom('a').hasAttribute('href', `/login`);
  });

Screen Shot 2021-03-08 at 9 29 56 AM

😕 Actual Behavior

Actual: Element has an empty attribute "href".

🤔 Expected Behavior

Element a has attribute "href" with value "/login"

🌍 Environment

Ember: 3.25.3

➕ Additional Context

#19408

@esbanarango esbanarango changed the title [Bug] Bug report [Bug] with ember-source 3.25.3: href empty from links in rendering tests Mar 8, 2021
@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2021

Hmm, I think this was an accidental issue? Since you opened the same thing over on buschtoens/ember-link#554, and Ember itself does not provide a (link helper.

I'm going to go ahead and close...

@rwjblue rwjblue closed this as completed Mar 8, 2021
@esbanarango
Copy link
Contributor Author

🤦‍♂️ Totally! Sorry about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants