You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems there is a bug in current canary where didDestroyElement is not being called on teardown. Funny enough when I search for didDestroyElement in this repo I get no hits :)
@rwjblue Indicated that a similar issue may have been fixed earlier here and just need to be re-applied.
The text was updated successfully, but these errors were encountered:
mitchlloyd
changed the title
[Glimmer 2]
[Glimmer 2] didDestroyElement and didDestroy need to be called during component teardown
Sep 2, 2016
mitchlloyd
changed the title
[Glimmer 2] didDestroyElement and didDestroy need to be called during component teardown
[Glimmer 2] didDestroyElement needs to be called during component teardown
Sep 2, 2016
Thanks for reporting! Yeah, we need to port forward the tests added in #14159 (which would be a good failing test for this). Once we have the failing tests, we need to add a view.trigger('didDestroyElement')around here. I need to check with @krisselden to see if didDestroyElement is supposed to be fired before view.destroy() is called though.
It seems there is a bug in current canary where
didDestroyElement
is not being called on teardown. Funny enough when I search fordidDestroyElement
in this repo I get no hits :)@rwjblue Indicated that a similar issue may have been fixed earlier here and just need to be re-applied.
https://github.com/emberjs/ember.js/pull/14159/files
The text was updated successfully, but these errors were encountered: