Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer 2] didDestroyElement needs to be called during component teardown #14185

Closed
mitchlloyd opened this issue Sep 2, 2016 · 2 comments
Closed

Comments

@mitchlloyd
Copy link
Contributor

mitchlloyd commented Sep 2, 2016

It seems there is a bug in current canary where didDestroyElement is not being called on teardown. Funny enough when I search for didDestroyElement in this repo I get no hits :)

@rwjblue Indicated that a similar issue may have been fixed earlier here and just need to be re-applied.

https://github.com/emberjs/ember.js/pull/14159/files

@mitchlloyd mitchlloyd changed the title [Glimmer 2] [Glimmer 2] didDestroyElement and didDestroy need to be called during component teardown Sep 2, 2016
@mitchlloyd mitchlloyd changed the title [Glimmer 2] didDestroyElement and didDestroy need to be called during component teardown [Glimmer 2] didDestroyElement needs to be called during component teardown Sep 2, 2016
@rwjblue
Copy link
Member

rwjblue commented Sep 2, 2016

Thanks for reporting! Yeah, we need to port forward the tests added in #14159 (which would be a good failing test for this). Once we have the failing tests, we need to add a view.trigger('didDestroyElement') around here. I need to check with @krisselden to see if didDestroyElement is supposed to be fired before view.destroy() is called though.

@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2016

Fixed by #14227.

@rwjblue rwjblue closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants