Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ember.Handlebars.SafeString. #13191

Closed
3 tasks
rwjblue opened this issue Mar 27, 2016 · 1 comment
Closed
3 tasks

Deprecate Ember.Handlebars.SafeString. #13191

rwjblue opened this issue Mar 27, 2016 · 1 comment

Comments

@rwjblue
Copy link
Member

rwjblue commented Mar 27, 2016

Suggest using Ember.String.htmlSafe over Ember.Handlebars.SafeString:

// deprecated
new Ember.Handlebars.SafeString(someString);

// Non-deprecated
Ember.String.htmlSafe(someString);

For a few reasons:

  • The SafeString API is a tad bit "trolly" (many questions arise from it "not working" due to forgetting to use new).
  • The Ember.Handlebars namespace is basically legacy and going away

The steps needed for this are:

  • Change this to use deprecateFunc.
  • Add an entry to the 2.x deprecation guide
  • Link to that deprecation guide entry in the deprecation added above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants