Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query params not updated by transitionTo/replaceWith during active transition #10262

Open
jesenko opened this issue Jan 22, 2015 · 5 comments
Open

Comments

@jesenko
Copy link

jesenko commented Jan 22, 2015

When entering a route, a call to transitionTo/replaceWith does not update query params when called prior to setupController hook.

Example:
http://jsbin.com/merivu/5/
clicking About should set thing qp to transitioned

@andrewbranch
Copy link

Could this be the underlying cause?

Keep in mind that if the arguments provided to transitionTo or link-to only correspond to a change in query param values, and not a change in the route hierarchy, it is not considered a full transition, which means that hooks like model and setupController won't fire by default, but rather only controller properties will be updated with new query param values, as will the URL.

transitionTo with query params works when doing a full transition, but in @jesenko’s example, theoretically “only controller properties will be updated” but the controller doesn’t exist yet.

@mmun mmun added Query Params and removed Bug labels Feb 21, 2016
@pixelhandler
Copy link
Contributor

@jesenko can you provide an updated example (reproduction of the issue) using a current release of Ember.js or the LTS release (2.4.6) ?

@pixelhandler
Copy link
Contributor

@andrewbranch @jesenko @mmun @wagenet is this still an issue, perhaps we should close or create a new reproduction of this, what do you think?

@arnaldo2792
Copy link

arnaldo2792 commented Mar 20, 2019

hey @pixelhandler this is still a "bug", I reproduced the error in this ember twiddle, I used v3.4.3:

https://ember-twiddle.com/1b49297f72c0de95987554d65e233685

@jesenko, could you please comment what is your use case for this? Maybe we can find a different way to do what you want?

@pixelhandler
Copy link
Contributor

@arnaldo2792 thanks for creating the reproduction :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants