reduce_computed_macros_test.js

import { run } from '@ember/runloop';
import {
  defineProperty,
  setProperties,
  get,
  set,
  addObserver,
  computed,
  observer,
} from '@ember/-internals/metal';
import {
  Object as EmberObject,
  ObjectProxy,
  isArray,
  A as emberA,
  removeAt,
} from '@ember/-internals/runtime';
import {
  sum,
  min,
  max,
  map,
  sort,
  setDiff,
  mapBy,
  filter,
  filterBy,
  uniq,
  uniqBy,
  union,
  intersect,
  collect,
} from '@ember/object/computed';
import { moduleFor, AbstractTestCase, runLoopSettled } from 'internal-test-helpers';

let obj;
moduleFor(
  'map',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        mapped: map('array.@each.v', item => item.v),
        mappedObjects: map('arrayObjects.@each.v', item => ({
          name: item.v.name,
        })),
      }).create({
        arrayObjects: emberA([{ v: { name: 'Robert' } }, { v: { name: 'Leanna' } }]),

        array: emberA([{ v: 1 }, { v: 3 }, { v: 2 }, { v: 1 }]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test map is readOnly'](assert) {
      assert.throws(function() {
        obj.set('mapped', 1);
      }, /Cannot set read-only property "mapped" on object:/);
    }

    ['@test it maps simple properties'](assert) {
      assert.deepEqual(obj.get('mapped'), [1, 3, 2, 1]);

      obj.get('array').pushObject({ v: 5 });

      assert.deepEqual(obj.get('mapped'), [1, 3, 2, 1, 5]);

      removeAt(obj.get('array'), 3);

      assert.deepEqual(obj.get('mapped'), [1, 3, 2, 5]);
    }

    ['@test it maps simple unshifted properties'](assert) {
      let array = emberA();

      obj = EmberObject.extend({
        mapped: map('array', item => item.toUpperCase()),
      }).create({
        array,
      });

      array.unshiftObject('c');
      array.unshiftObject('b');
      array.unshiftObject('a');

      array.popObject();

      assert.deepEqual(
        obj.get('mapped'),
        ['A', 'B'],
        'properties unshifted in sequence are mapped correctly'
      );
    }

    ['@test it has the correct `this`'](assert) {
      obj = EmberObject.extend({
        mapped: map('array', function(item) {
          assert.equal(this, obj, 'should have correct context');
          return this.upperCase(item);
        }),
        upperCase(string) {
          return string.toUpperCase();
        },
      }).create({
        array: ['a', 'b', 'c'],
      });

      assert.deepEqual(
        obj.get('mapped'),
        ['A', 'B', 'C'],
        'properties unshifted in sequence are mapped correctly'
      );
    }

    ['@test it passes the index to the callback'](assert) {
      let array = ['a', 'b', 'c'];

      obj = EmberObject.extend({
        mapped: map('array', (item, index) => index),
      }).create({
        array,
      });

      assert.deepEqual(obj.get('mapped'), [0, 1, 2], 'index is passed to callback correctly');
    }

    ['@test it maps objects'](assert) {
      assert.deepEqual(obj.get('mappedObjects'), [{ name: 'Robert' }, { name: 'Leanna' }]);

      obj.get('arrayObjects').pushObject({
        v: { name: 'Eddard' },
      });

      assert.deepEqual(obj.get('mappedObjects'), [
        { name: 'Robert' },
        { name: 'Leanna' },
        { name: 'Eddard' },
      ]);

      removeAt(obj.get('arrayObjects'), 1);

      assert.deepEqual(obj.get('mappedObjects'), [{ name: 'Robert' }, { name: 'Eddard' }]);

      set(obj.get('arrayObjects')[0], 'v', { name: 'Stannis' });

      assert.deepEqual(obj.get('mappedObjects'), [{ name: 'Stannis' }, { name: 'Eddard' }]);
    }

    ['@test it maps unshifted objects with property observers'](assert) {
      let array = emberA();
      let cObj = { v: 'c' };

      obj = EmberObject.extend({
        mapped: map('array.@each.v', item => get(item, 'v').toUpperCase()),
      }).create({
        array,
      });

      array.unshiftObject(cObj);
      array.unshiftObject({ v: 'b' });
      array.unshiftObject({ v: 'a' });

      set(cObj, 'v', 'd');

      assert.deepEqual(array.mapBy('v'), ['a', 'b', 'd'], 'precond - unmapped array is correct');
      assert.deepEqual(
        obj.get('mapped'),
        ['A', 'B', 'D'],
        'properties unshifted in sequence are mapped correctly'
      );
    }

    ['@test it updates if additional dependent keys are modified'](assert) {
      obj = EmberObject.extend({
        mapped: map('array', ['key'], function(item) {
          return item[this.key];
        }),
      }).create({
        key: 'name',
        array: emberA([{ name: 'Cercei', house: 'Lannister' }]),
      });

      assert.deepEqual(
        obj.get('mapped'),
        ['Cercei'],
        'precond - mapped array is initially correct'
      );

      obj.set('key', 'house');
      assert.deepEqual(
        obj.get('mapped'),
        ['Lannister'],
        'mapped prop updates correctly when additional dependency is updated'
      );
    }

    ['@test it throws on bad inputs']() {
      expectAssertion(() => {
        map('items.@each.{prop}', 'foo');
      }, /The final parameter provided to map must be a callback function/);

      expectAssertion(() => {
        map('items.@each.{prop}', 'foo', function() {});
      }, /The second parameter provided to map must either be the callback or an array of additional dependent keys/);

      expectAssertion(() => {
        map('items.@each.{prop}', function() {}, ['foo']);
      }, /The final parameter provided to map must be a callback function/);

      expectAssertion(() => {
        map('items.@each.{prop}', ['foo']);
      }, /The final parameter provided to map must be a callback function/);
    }
  }
);

moduleFor(
  'mapBy',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        mapped: mapBy('array', 'v'),
      }).create({
        array: emberA([{ v: 1 }, { v: 3 }, { v: 2 }, { v: 1 }]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test mapBy is readOnly'](assert) {
      assert.throws(function() {
        obj.set('mapped', 1);
      }, /Cannot set read-only property "mapped" on object:/);
    }

    ['@test it maps properties'](assert) {
      assert.deepEqual(obj.get('mapped'), [1, 3, 2, 1]);

      obj.get('array').pushObject({ v: 5 });

      assert.deepEqual(obj.get('mapped'), [1, 3, 2, 1, 5]);

      removeAt(obj.get('array'), 3);

      assert.deepEqual(obj.get('mapped'), [1, 3, 2, 5]);
    }

    async ['@test it is observable'](assert) {
      let calls = 0;

      assert.deepEqual(obj.get('mapped'), [1, 3, 2, 1]);

      addObserver(obj, 'mapped.@each', () => calls++);

      obj.get('array').pushObject({ v: 5 });
      await runLoopSettled();

      assert.equal(calls, 1, 'mapBy is observable');
    }
  }
);

moduleFor(
  'filter',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        filtered: filter('array', item => item % 2 === 0),
      }).create({
        array: emberA([1, 2, 3, 4, 5, 6, 7, 8]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test filter is readOnly'](assert) {
      assert.throws(function() {
        obj.set('filtered', 1);
      }, /Cannot set read-only property "filtered" on object:/);
    }

    ['@test it filters according to the specified filter function'](assert) {
      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8],
        'filter filters by the specified function'
      );
    }

    ['@test it passes the index to the callback'](assert) {
      obj = EmberObject.extend({
        filtered: filter('array', (item, index) => index === 1),
      }).create({
        array: ['a', 'b', 'c'],
      });

      assert.deepEqual(get(obj, 'filtered'), ['b'], 'index is passed to callback correctly');
    }

    ['@test it has the correct `this`'](assert) {
      obj = EmberObject.extend({
        filtered: filter('array', function(item, index) {
          assert.equal(this, obj);
          return this.isOne(index);
        }),
        isOne(value) {
          return value === 1;
        },
      }).create({
        array: ['a', 'b', 'c'],
      });

      assert.deepEqual(get(obj, 'filtered'), ['b'], 'index is passed to callback correctly');
    }

    ['@test it passes the array to the callback'](assert) {
      obj = EmberObject.extend({
        filtered: filter('array', (item, index, array) => index === get(array, 'length') - 2),
      }).create({
        array: emberA(['a', 'b', 'c']),
      });

      assert.deepEqual(obj.get('filtered'), ['b'], 'array is passed to callback correctly');
    }

    ['@test it caches properly'](assert) {
      let array = obj.get('array');

      let filtered = obj.get('filtered');
      assert.ok(filtered === obj.get('filtered'));

      array.addObject(11);
      let newFiltered = obj.get('filtered');

      assert.ok(filtered !== newFiltered);

      assert.ok(obj.get('filtered') === newFiltered);
    }

    ['@test it updates as the array is modified'](assert) {
      let array = obj.get('array');

      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8],
        'precond - filtered array is initially correct'
      );

      array.addObject(11);
      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8],
        'objects not passing the filter are not added'
      );

      array.addObject(12);
      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8, 12],
        'objects passing the filter are added'
      );

      array.removeObject(3);
      array.removeObject(4);

      assert.deepEqual(
        obj.get('filtered'),
        [2, 6, 8, 12],
        'objects removed from the dependent array are removed from the computed array'
      );
    }

    ['@test the dependent array can be cleared one at a time'](assert) {
      let array = get(obj, 'array');

      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8],
        'precond - filtered array is initially correct'
      );

      // clear 1-8 but in a random order
      array.removeObject(3);
      array.removeObject(1);
      array.removeObject(2);
      array.removeObject(4);
      array.removeObject(8);
      array.removeObject(6);
      array.removeObject(5);
      array.removeObject(7);

      assert.deepEqual(obj.get('filtered'), [], 'filtered array cleared correctly');
    }

    ['@test the dependent array can be `clear`ed directly (#3272)'](assert) {
      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8],
        'precond - filtered array is initially correct'
      );

      obj.get('array').clear();

      assert.deepEqual(obj.get('filtered'), [], 'filtered array cleared correctly');
    }

    ['@test it updates as the array is replaced'](assert) {
      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8],
        'precond - filtered array is initially correct'
      );

      obj.set('array', [20, 21, 22, 23, 24]);

      assert.deepEqual(
        obj.get('filtered'),
        [20, 22, 24],
        'computed array is updated when array is changed'
      );
    }

    ['@test it updates properly on @each with {} dependencies'](assert) {
      let item = EmberObject.create({ prop: true });

      obj = EmberObject.extend({
        filtered: filter('items.@each.{prop}', function(item) {
          return item.get('prop') === true;
        }),
      }).create({
        items: emberA([item]),
      });

      assert.deepEqual(obj.get('filtered'), [item]);

      item.set('prop', false);

      assert.deepEqual(obj.get('filtered'), []);
    }

    ['@test it updates if additional dependent keys are modified'](assert) {
      obj = EmberObject.extend({
        filtered: filter('array', ['modulo'], function(item) {
          return item % this.modulo === 0;
        }),
      }).create({
        modulo: 2,
        array: emberA([1, 2, 3, 4, 5, 6, 7, 8]),
      });

      assert.deepEqual(
        obj.get('filtered'),
        [2, 4, 6, 8],
        'precond - filtered array is initially correct'
      );

      obj.set('modulo', 3);
      assert.deepEqual(
        obj.get('filtered'),
        [3, 6],
        'filtered prop updates correctly when additional dependency is updated'
      );
    }

    ['@test it throws on bad inputs']() {
      expectAssertion(() => {
        filter('items.@each.{prop}', 'foo');
      }, /The final parameter provided to filter must be a callback function/);

      expectAssertion(() => {
        filter('items.@each.{prop}', 'foo', function() {});
      }, /The second parameter provided to filter must either be the callback or an array of additional dependent keys/);

      expectAssertion(() => {
        filter('items.@each.{prop}', function() {}, ['foo']);
      }, /The final parameter provided to filter must be a callback function/);

      expectAssertion(() => {
        filter('items.@each.{prop}', ['foo']);
      }, /The final parameter provided to filter must be a callback function/);
    }
  }
);

moduleFor(
  'filterBy',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        a1s: filterBy('array', 'a', 1),
        as: filterBy('array', 'a'),
        bs: filterBy('array', 'b'),
      }).create({
        array: emberA([
          { name: 'one', a: 1, b: false },
          { name: 'two', a: 2, b: false },
          { name: 'three', a: 1, b: true },
          { name: 'four', b: true },
        ]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test filterBy is readOnly'](assert) {
      assert.throws(function() {
        obj.set('as', 1);
      }, /Cannot set read-only property "as" on object:/);
    }

    ['@test properties can be filtered by truthiness'](assert) {
      assert.deepEqual(
        obj.get('as').mapBy('name'),
        ['one', 'two', 'three'],
        'properties can be filtered by existence'
      );
      assert.deepEqual(obj.get('bs').mapBy('name'), ['three', 'four'], 'booleans can be filtered');

      set(obj.get('array')[0], 'a', undefined);
      set(obj.get('array')[3], 'a', true);

      set(obj.get('array')[0], 'b', true);
      set(obj.get('array')[3], 'b', false);

      assert.deepEqual(
        obj.get('as').mapBy('name'),
        ['two', 'three', 'four'],
        'arrays computed by filter property respond to property changes'
      );
      assert.deepEqual(
        obj.get('bs').mapBy('name'),
        ['one', 'three'],
        'arrays computed by filtered property respond to property changes'
      );

      obj.get('array').pushObject({ name: 'five', a: 6, b: true });

      assert.deepEqual(
        obj.get('as').mapBy('name'),
        ['two', 'three', 'four', 'five'],
        'arrays computed by filter property respond to added objects'
      );
      assert.deepEqual(
        obj.get('bs').mapBy('name'),
        ['one', 'three', 'five'],
        'arrays computed by filtered property respond to added objects'
      );

      obj.get('array').popObject();

      assert.deepEqual(
        obj.get('as').mapBy('name'),
        ['two', 'three', 'four'],
        'arrays computed by filter property respond to removed objects'
      );
      assert.deepEqual(
        obj.get('bs').mapBy('name'),
        ['one', 'three'],
        'arrays computed by filtered property respond to removed objects'
      );

      obj.set('array', [{ name: 'six', a: 12, b: true }]);

      assert.deepEqual(
        obj.get('as').mapBy('name'),
        ['six'],
        'arrays computed by filter property respond to array changes'
      );
      assert.deepEqual(
        obj.get('bs').mapBy('name'),
        ['six'],
        'arrays computed by filtered property respond to array changes'
      );
    }

    ['@test properties can be filtered by values'](assert) {
      assert.deepEqual(
        obj.get('a1s').mapBy('name'),
        ['one', 'three'],
        'properties can be filtered by matching value'
      );

      obj.get('array').pushObject({ name: 'five', a: 1 });

      assert.deepEqual(
        obj.get('a1s').mapBy('name'),
        ['one', 'three', 'five'],
        'arrays computed by matching value respond to added objects'
      );

      obj.get('array').popObject();

      assert.deepEqual(
        obj.get('a1s').mapBy('name'),
        ['one', 'three'],
        'arrays computed by matching value respond to removed objects'
      );

      set(obj.get('array')[1], 'a', 1);
      set(obj.get('array')[2], 'a', 2);

      assert.deepEqual(
        obj.get('a1s').mapBy('name'),
        ['one', 'two'],
        'arrays computed by matching value respond to modified properties'
      );
    }

    ['@test properties values can be replaced'](assert) {
      obj = EmberObject.extend({
        a1s: filterBy('array', 'a', 1),
        a1bs: filterBy('a1s', 'b'),
      }).create({
        array: [],
      });

      assert.deepEqual(
        obj.get('a1bs').mapBy('name'),
        [],
        'properties can be filtered by matching value'
      );

      set(obj, 'array', [{ name: 'item1', a: 1, b: true }]);

      assert.deepEqual(
        obj.get('a1bs').mapBy('name'),
        ['item1'],
        'properties can be filtered by matching value'
      );
    }
  }
);

[['uniq', uniq], ['union', union]].forEach(tuple => {
  let [name, macro] = tuple;

  moduleFor(
    `computed.${name}`,
    class extends AbstractTestCase {
      beforeEach() {
        obj = EmberObject.extend({
          union: macro('array', 'array2', 'array3'),
        }).create({
          array: emberA([1, 2, 3, 4, 5, 6]),
          array2: emberA([4, 5, 6, 7, 8, 9, 4, 5, 6, 7, 8, 9]),
          array3: emberA([1, 8, 10]),
        });
      }

      afterEach() {
        run(obj, 'destroy');
      }

      [`@test ${name} is readOnly`](assert) {
        assert.throws(function() {
          obj.set('union', 1);
        }, /Cannot set read-only property "union" on object:/);
      }

      ['@test does not include duplicates'](assert) {
        let array = obj.get('array');
        let array2 = obj.get('array2');

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
          name + ' does not include duplicates'
        );

        array.pushObject(8);

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
          name + ' does not add existing items'
        );

        array.pushObject(11);

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11],
          name + ' adds new items'
        );

        removeAt(array2, 6); // remove 7

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11],
          name + ' does not remove items that are still in the dependent array'
        );

        array2.removeObject(7);

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 2, 3, 4, 5, 6, 8, 9, 10, 11],
          name + ' removes items when their last instance is gone'
        );
      }

      ['@test has set-union semantics'](assert) {
        let array = obj.get('array');

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
          name + ' is initially correct'
        );

        array.removeObject(6);

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
          'objects are not removed if they exist in other dependent arrays'
        );

        array.clear();

        assert.deepEqual(
          obj.get('union').sort((x, y) => x - y),
          [1, 4, 5, 6, 7, 8, 9, 10],
          'objects are removed when they are no longer in any dependent array'
        );
      }
    }
  );
});

moduleFor(
  'computed.uniqBy',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        list: null,
        uniqueById: uniqBy('list', 'id'),
      }).create({
        list: emberA([{ id: 1, value: 'one' }, { id: 2, value: 'two' }, { id: 1, value: 'one' }]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test uniqBy is readOnly'](assert) {
      assert.throws(function() {
        obj.set('uniqueById', 1);
      }, /Cannot set read-only property "uniqueById" on object:/);
    }
    ['@test does not include duplicates'](assert) {
      assert.deepEqual(obj.get('uniqueById'), [{ id: 1, value: 'one' }, { id: 2, value: 'two' }]);
    }

    ['@test it does not share state among instances'](assert) {
      let MyObject = EmberObject.extend({
        list: [],
        uniqueByName: uniqBy('list', 'name'),
      });
      let a = MyObject.create({
        list: [{ name: 'bob' }, { name: 'mitch' }, { name: 'mitch' }],
      });
      let b = MyObject.create({
        list: [{ name: 'warren' }, { name: 'mitch' }],
      });

      assert.deepEqual(a.get('uniqueByName'), [{ name: 'bob' }, { name: 'mitch' }]);
      // Making sure that 'mitch' appears
      assert.deepEqual(b.get('uniqueByName'), [{ name: 'warren' }, { name: 'mitch' }]);
    }

    ['@test it handles changes to the dependent array'](assert) {
      obj.get('list').pushObject({ id: 3, value: 'three' });

      assert.deepEqual(
        obj.get('uniqueById'),
        [{ id: 1, value: 'one' }, { id: 2, value: 'two' }, { id: 3, value: 'three' }],
        'The list includes three'
      );

      obj.get('list').pushObject({ id: 3, value: 'three' });

      assert.deepEqual(
        obj.get('uniqueById'),
        [{ id: 1, value: 'one' }, { id: 2, value: 'two' }, { id: 3, value: 'three' }],
        'The list does not include a duplicate three'
      );
    }

    ['@test it returns an empty array when computed on a non-array'](assert) {
      let MyObject = EmberObject.extend({
        list: null,
        uniq: uniqBy('list', 'name'),
      });
      let a = MyObject.create({ list: 'not an array' });

      assert.deepEqual(a.get('uniq'), []);
    }
  }
);

moduleFor(
  'computed.intersect',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        intersection: intersect('array', 'array2', 'array3'),
      }).create({
        array: emberA([1, 2, 3, 4, 5, 6]),
        array2: emberA([3, 3, 3, 4, 5]),
        array3: emberA([3, 5, 6, 7, 8]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test intersect is readOnly'](assert) {
      assert.throws(function() {
        obj.set('intersection', 1);
      }, /Cannot set read-only property "intersection" on object:/);
    }

    ['@test it has set-intersection semantics'](assert) {
      let array2 = obj.get('array2');
      let array3 = obj.get('array3');

      assert.deepEqual(
        obj.get('intersection').sort((x, y) => x - y),
        [3, 5],
        'intersection is initially correct'
      );

      array2.shiftObject();

      assert.deepEqual(
        obj.get('intersection').sort((x, y) => x - y),
        [3, 5],
        'objects are not removed when they are still in all dependent arrays'
      );

      array2.shiftObject();

      assert.deepEqual(
        obj.get('intersection').sort((x, y) => x - y),
        [3, 5],
        'objects are not removed when they are still in all dependent arrays'
      );

      array2.shiftObject();

      assert.deepEqual(
        obj.get('intersection'),
        [5],
        'objects are removed once they are gone from all dependent arrays'
      );

      array2.pushObject(1);

      assert.deepEqual(
        obj.get('intersection'),
        [5],
        'objects are not added as long as they are missing from any dependent array'
      );

      array3.pushObject(1);

      assert.deepEqual(
        obj.get('intersection').sort((x, y) => x - y),
        [1, 5],
        'objects added once they belong to all dependent arrays'
      );
    }
  }
);

moduleFor(
  'setDiff',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        diff: setDiff('array', 'array2'),
      }).create({
        array: emberA([1, 2, 3, 4, 5, 6, 7]),
        array2: emberA([3, 4, 5, 10]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test setDiff is readOnly'](assert) {
      assert.throws(function() {
        obj.set('diff', 1);
      }, /Cannot set read-only property "diff" on object:/);
    }

    ['@test it asserts if given fewer or more than two dependent properties']() {
      expectAssertion(
        function() {
          EmberObject.extend({
            diff: setDiff('array'),
          }).create({
            array: emberA([1, 2, 3, 4, 5, 6, 7]),
            array2: emberA([3, 4, 5]),
          });
        },
        /`computed\.setDiff` requires exactly two dependent arrays/,
        'setDiff requires two dependent arrays'
      );

      expectAssertion(
        function() {
          EmberObject.extend({
            diff: setDiff('array', 'array2', 'array3'),
          }).create({
            array: emberA([1, 2, 3, 4, 5, 6, 7]),
            array2: emberA([3, 4, 5]),
            array3: emberA([7]),
          });
        },
        /`computed\.setDiff` requires exactly two dependent arrays/,
        'setDiff requires two dependent arrays'
      );
    }

    ['@test it has set-diff semantics'](assert) {
      let array1 = obj.get('array');
      let array2 = obj.get('array2');

      assert.deepEqual(
        obj.get('diff').sort((x, y) => x - y),
        [1, 2, 6, 7],
        'set-diff is initially correct'
      );

      array2.popObject();

      assert.deepEqual(
        obj.get('diff').sort((x, y) => x - y),
        [1, 2, 6, 7],
        'removing objects from the remove set has no effect if the object is not in the keep set'
      );

      array2.shiftObject();

      assert.deepEqual(
        obj.get('diff').sort((x, y) => x - y),
        [1, 2, 3, 6, 7],
        "removing objects from the remove set adds them if they're in the keep set"
      );

      array1.removeObject(3);

      assert.deepEqual(
        obj.get('diff').sort((x, y) => x - y),
        [1, 2, 6, 7],
        'removing objects from the keep array removes them from the computed array'
      );

      array1.pushObject(5);

      assert.deepEqual(
        obj.get('diff').sort((x, y) => x - y),
        [1, 2, 6, 7],
        'objects added to the keep array that are in the remove array are not added to the computed array'
      );

      array1.pushObject(22);

      assert.deepEqual(
        obj.get('diff').sort((x, y) => x - y),
        [1, 2, 6, 7, 22],
        'objects added to the keep array not in the remove array are added to the computed array'
      );
    }
  }
);

class SortWithSortPropertiesTestCase extends AbstractTestCase {
  beforeEach() {
    this.obj = this.buildObject();
  }

  afterEach() {
    if (this.obj) {
      this.cleanupObject();
    }
  }

  ['@test sort is readOnly'](assert) {
    assert.throws(() => {
      set(this.obj, 'sortedItems', 1);
    }, /Cannot set read-only property "sortedItems" on object:/);
  }

  ['@test arrays are initially sorted'](assert) {
    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'array is initially sorted'
    );
  }

  ['@test default sort order is correct'](assert) {
    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'array is initially sorted'
    );
  }

  ['@test changing the dependent array updates the sorted array'](assert) {
    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    set(this.obj, 'items', [
      { fname: 'Roose', lname: 'Bolton' },
      { fname: 'Theon', lname: 'Greyjoy' },
      { fname: 'Ramsey', lname: 'Bolton' },
      { fname: 'Stannis', lname: 'Baratheon' },
    ]);

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Stannis', 'Ramsey', 'Roose', 'Theon'],
      'changing dependent array updates sorted array'
    );
  }

  ['@test adding to the dependent array updates the sorted array'](assert) {
    let items = this.obj.items;

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    items.pushObject({
      fname: 'Tyrion',
      lname: 'Lannister',
    });

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Tyrion', 'Bran', 'Robb'],
      'Adding to the dependent array updates the sorted array'
    );
  }

  ['@test removing from the dependent array updates the sorted array'](assert) {
    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    this.obj.items.popObject();

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Robb'],
      'Removing from the dependent array updates the sorted array'
    );
  }

  ['@test distinct items may be sort-equal, although their relative order will not be guaranteed'](
    assert
  ) {
    // We recreate jaime and "Cersei" here only for test stability: we want
    // their guid-ordering to be deterministic
    let jaimeInDisguise = {
      fname: 'Cersei',
      lname: 'Lannister',
      age: 34,
    };

    let jaime = {
      fname: 'Jaime',
      lname: 'Lannister',
      age: 34,
    };

    let items = this.obj.items;

    items.replace(0, 1, [jaime]);
    items.replace(1, 1, [jaimeInDisguise]);

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    set(jaimeInDisguise, 'fname', 'Jaime');

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Jaime', 'Jaime', 'Bran', 'Robb'],
      'sorted array is updated'
    );

    set(jaimeInDisguise, 'fname', 'Cersei');

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'sorted array is updated'
    );
  }

  ['@test guid sort-order fallback with a search proxy is not confused by non-search ObjectProxys'](
    assert
  ) {
    let tyrion = {
      fname: 'Tyrion',
      lname: 'Lannister',
    };

    let tyrionInDisguise = ObjectProxy.create({
      fname: 'Yollo',
      lname: '',
      content: tyrion,
    });

    let items = this.obj.items;

    items.pushObject(tyrion);

    assert.deepEqual(this.obj.sortedItems.mapBy('fname'), [
      'Cersei',
      'Jaime',
      'Tyrion',
      'Bran',
      'Robb',
    ]);

    items.pushObject(tyrionInDisguise);

    assert.deepEqual(this.obj.sortedItems.mapBy('fname'), [
      'Yollo',
      'Cersei',
      'Jaime',
      'Tyrion',
      'Bran',
      'Robb',
    ]);
  }

  ['@test updating sort properties detaches observers for old sort properties'](assert) {
    let objectToRemove = this.obj.items[3];

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    set(this.obj, 'itemSorting', emberA(['fname:desc']));

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Robb', 'Jaime', 'Cersei', 'Bran'],
      'after updating sort properties array is updated'
    );

    this.obj.items.removeObject(objectToRemove);

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Robb', 'Jaime', 'Cersei'],
      'after removing item array is updated'
    );

    set(objectToRemove, 'lname', 'Updated-Stark');

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Robb', 'Jaime', 'Cersei'],
      'after changing removed item array is not updated'
    );
  }

  ['@test sort works if array property is null (non array value) on first evaluation of computed prop'](
    assert
  ) {
    set(this.obj, 'items', null);
    assert.deepEqual(this.obj.sortedItems, []);
    set(this.obj, 'items', emberA([{ fname: 'Cersei', lname: 'Lanister' }]));
    assert.deepEqual(this.obj.sortedItems, [{ fname: 'Cersei', lname: 'Lanister' }]);
  }

  ['@test updating sort properties updates the sorted array'](assert) {
    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    set(this.obj, 'itemSorting', emberA(['fname:desc']));

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Robb', 'Jaime', 'Cersei', 'Bran'],
      'after updating sort properties array is updated'
    );
  }

  ['@test updating sort properties invalidates the sorted array'](assert) {
    let sortProps = this.obj.itemSorting;

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    sortProps.clear();
    sortProps.pushObject('fname');

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Bran', 'Cersei', 'Jaime', 'Robb'],
      'after updating sort properties array is updated'
    );
  }

  ['@test updating new sort properties invalidates the sorted array'](assert) {
    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    set(this.obj, 'itemSorting', emberA(['age:desc', 'fname:asc']));

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Robb', 'Bran'],
      'precond - array is correct after item sorting is changed'
    );

    set(this.obj.items[1], 'age', 29);

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Jaime', 'Cersei', 'Robb', 'Bran'],
      'after updating sort properties array is updated'
    );
  }

  ['@test sort direction defaults to ascending'](assert) {
    assert.deepEqual(this.obj.sortedItems.mapBy('fname'), ['Cersei', 'Jaime', 'Bran', 'Robb']);
  }

  ['@test sort direction defaults to ascending (with sort property change)'](assert) {
    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    set(this.obj, 'itemSorting', emberA(['fname']));

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Bran', 'Cersei', 'Jaime', 'Robb'],
      'sort direction defaults to ascending'
    );
  }

  ["@test updating an item's sort properties updates the sorted array"](assert) {
    let tyrionInDisguise = this.obj.items[1];

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    set(tyrionInDisguise, 'fname', 'Tyrion');

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Jaime', 'Tyrion', 'Bran', 'Robb'],
      "updating an item's sort properties updates the sorted array"
    );
  }

  ["@test updating several of an item's sort properties updated the sorted array"](assert) {
    let sansaInDisguise = this.obj.items[1];

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Cersei', 'Jaime', 'Bran', 'Robb'],
      'precond - array is initially sorted'
    );

    setProperties(sansaInDisguise, {
      fname: 'Sansa',
      lname: 'Stark',
    });

    assert.deepEqual(
      this.obj.sortedItems.mapBy('fname'),
      ['Jaime', 'Bran', 'Robb', 'Sansa'],
      "updating an item's sort properties updates the sorted array"
    );
  }

  ["@test updating an item's sort properties does not error when binary search does a self compare (#3273)"](
    assert
  ) {
    let jaime = {
      name: 'Jaime',
      status: 1,
    };

    let cersei = {
      name: 'Cersei',
      status: 2,
    };

    this.cleanupObject();
    this.obj = this.buildObject([jaime, cersei], ['status']);

    assert.deepEqual(this.obj.sortedItems, [jaime, cersei], 'precond - array is initially sorted');

    set(cersei, 'status', 3);

    assert.deepEqual(this.obj.sortedItems, [jaime, cersei], 'array is sorted correctly');

    set(cersei, 'status', 2);

    assert.deepEqual(this.obj.sortedItems, [jaime, cersei], 'array is sorted correctly');
  }

  ['@test array should not be sorted if sort properties array is empty'](assert) {
    this.cleanupObject();
    // This bug only manifests when array.sort(() => 0) is not equal to array.
    // In order for this to happen, the browser must use an unstable sort and the
    // array must be sufficient large. On Chrome, 12 items is currently sufficient.
    this.obj = this.buildObject(emberA([6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4, 5]), []);

    assert.deepEqual(
      this.obj.sortedItems,
      [6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4, 5],
      'array is not changed'
    );
  }

  ['@test array should update if items to be sorted is replaced when sort properties array is empty'](
    assert
  ) {
    this.cleanupObject();
    this.obj = this.buildObject(emberA([6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4, 5]), emberA([]));

    assert.deepEqual(
      this.obj.sortedItems,
      [6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4, 5],
      'array is not changed'
    );

    set(this.obj, 'items', emberA([5, 6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4]));

    assert.deepEqual(
      this.obj.sortedItems,
      [5, 6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4],
      'array was updated'
    );
  }

  ['@test array should update if items to be sorted is mutated when sort properties array is empty'](
    assert
  ) {
    this.cleanupObject();
    this.obj = this.buildObject(emberA([6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4, 5]), emberA([]));

    assert.deepEqual(
      this.obj.sortedItems,
      [6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4, 5],
      'array is not changed'
    );

    this.obj.items.pushObject(12);

    assert.deepEqual(
      this.obj.sortedItems,
      [6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4, 5, 12],
      'array was updated'
    );
  }

  ['@test array observers do not leak'](assert) {
    let daria = { name: 'Daria' };
    let jane = { name: 'Jane' };

    let sisters = [jane, daria];
    let sortProps = emberA(['name']);

    this.cleanupObject();
    this.obj = this.buildObject(sisters, sortProps);

    this.obj.sortedItems;
    this.cleanupObject();

    try {
      sortProps.pushObject({
        name: 'Anna',
      });
      assert.ok(true);
    } catch (e) {
      assert.ok(false, e);
    }
  }

  ['@test property paths in sort properties update the sorted array'](assert) {
    let jaime = {
      relatedObj: { status: 1, firstName: 'Jaime', lastName: 'Lannister' },
    };

    let cersei = {
      relatedObj: { status: 2, firstName: 'Cersei', lastName: 'Lannister' },
    };

    let sansa = EmberObject.create({
      relatedObj: { status: 3, firstName: 'Sansa', lastName: 'Stark' },
    });

    this.cleanupObject();
    this.obj = this.buildObject([jaime, cersei, sansa], ['relatedObj.status']);

    assert.deepEqual(
      this.obj.sortedItems,
      [jaime, cersei, sansa],
      'precond - array is initially sorted'
    );

    set(cersei, 'status', 3);

    assert.deepEqual(this.obj.sortedItems, [jaime, cersei, sansa], 'array is sorted correctly');

    set(cersei, 'status', 1);

    assert.deepEqual(this.obj.sortedItems, [jaime, cersei, sansa], 'array is sorted correctly');

    sansa.set('status', 1);

    assert.deepEqual(this.obj.sortedItems, [jaime, cersei, sansa], 'array is sorted correctly');

    set(this.obj, 'itemSorting', ['relatedObj.firstName']);

    assert.deepEqual(this.obj.sortedItems, [cersei, jaime, sansa], 'array is sorted correctly');
  }

  ['@test if the dependentKey is neither an array nor object, it will return an empty array'](
    assert
  ) {
    set(this.obj, 'items', null);
    assert.ok(isArray(this.obj.sortedItems), 'returns an empty arrays');

    set(this.obj, 'array', undefined);
    assert.ok(isArray(this.obj.sortedItems), 'returns an empty arrays');

    set(this.obj, 'array', 'not an array');
    assert.ok(isArray(this.obj.sortedItems), 'returns an empty arrays');
  }
}

moduleFor(
  'sort - sortProperties - Ember.Object',
  class extends SortWithSortPropertiesTestCase {
    buildObject(_items, _itemSorting) {
      let items =
        _items ||
        emberA([
          { fname: 'Jaime', lname: 'Lannister', age: 34 },
          { fname: 'Cersei', lname: 'Lannister', age: 34 },
          { fname: 'Robb', lname: 'Stark', age: 16 },
          { fname: 'Bran', lname: 'Stark', age: 8 },
        ]);

      let itemSorting = _itemSorting || emberA(['lname', 'fname']);

      return EmberObject.extend({
        sortedItems: sort('items', 'itemSorting'),
      }).create({
        itemSorting,
        items,
      });
    }

    cleanupObject() {
      run(this.obj, 'destroy');
    }
  }
);

moduleFor(
  'sort - sortProperties - Native Class',
  class extends SortWithSortPropertiesTestCase {
    buildObject(_items, _itemSorting) {
      let items =
        _items ||
        emberA([
          { fname: 'Jaime', lname: 'Lannister', age: 34 },
          { fname: 'Cersei', lname: 'Lannister', age: 34 },
          { fname: 'Robb', lname: 'Stark', age: 16 },
          { fname: 'Bran', lname: 'Stark', age: 8 },
        ]);

      let itemSorting = _itemSorting || emberA(['lname', 'fname']);

      return new (class {
        items = items;
        itemSorting = itemSorting;

        @sort('items', 'itemSorting')
        sortedItems;
      })();
    }

    cleanupObject() {}
  }
);

function sortByLnameFname(a, b) {
  let lna = get(a, 'lname');
  let lnb = get(b, 'lname');

  if (lna !== lnb) {
    return lna > lnb ? 1 : -1;
  }

  return sortByFnameAsc(a, b);
}

function sortByFnameAsc(a, b) {
  let fna = get(a, 'fname');
  let fnb = get(b, 'fname');

  if (fna === fnb) {
    return 0;
  }
  return fna > fnb ? 1 : -1;
}

moduleFor(
  'sort - sort function',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        sortedItems: sort('items.@each.fname', sortByLnameFname),
      }).create({
        items: emberA([
          { fname: 'Jaime', lname: 'Lannister', age: 34 },
          { fname: 'Cersei', lname: 'Lannister', age: 34 },
          { fname: 'Robb', lname: 'Stark', age: 16 },
          { fname: 'Bran', lname: 'Stark', age: 8 },
        ]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test sort has correct `this`'](assert) {
      let obj = EmberObject.extend({
        sortedItems: sort('items.@each.fname', function(a, b) {
          assert.equal(this, obj, 'expected the object to be `this`');
          return this.sortByLastName(a, b);
        }),
        sortByLastName(a, b) {
          return sortByFnameAsc(a, b);
        },
      }).create({
        items: emberA([
          { fname: 'Jaime', lname: 'Lannister', age: 34 },
          { fname: 'Cersei', lname: 'Lannister', age: 34 },
          { fname: 'Robb', lname: 'Stark', age: 16 },
          { fname: 'Bran', lname: 'Stark', age: 8 },
        ]),
      });

      obj.get('sortedItems');
    }

    ['@test sort (with function) is readOnly'](assert) {
      assert.throws(function() {
        obj.set('sortedItems', 1);
      }, /Cannot set read-only property "sortedItems" on object:/);
    }

    ['@test arrays are initially sorted'](assert) {
      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'array is initially sorted'
      );
    }

    ['@test default sort order is correct'](assert) {
      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'array is initially sorted'
      );
    }

    ['@test changing the dependent array updates the sorted array'](assert) {
      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'precond - array is initially sorted'
      );

      obj.set('items', [
        { fname: 'Roose', lname: 'Bolton' },
        { fname: 'Theon', lname: 'Greyjoy' },
        { fname: 'Ramsey', lname: 'Bolton' },
        { fname: 'Stannis', lname: 'Baratheon' },
      ]);

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Stannis', 'Ramsey', 'Roose', 'Theon'],
        'changing dependent array updates sorted array'
      );
    }

    ['@test adding to the dependent array updates the sorted array'](assert) {
      let items = obj.get('items');

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'precond - array is initially sorted'
      );

      items.pushObject({
        fname: 'Tyrion',
        lname: 'Lannister',
      });

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Tyrion', 'Bran', 'Robb'],
        'Adding to the dependent array updates the sorted array'
      );
    }

    ['@test removing from the dependent array updates the sorted array'](assert) {
      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'precond - array is initially sorted'
      );

      obj.get('items').popObject();

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Robb'],
        'Removing from the dependent array updates the sorted array'
      );
    }

    ['@test distinct items may be sort-equal, although their relative order will not be guaranteed'](
      assert
    ) {
      // We recreate jaime and "Cersei" here only for test stability: we want
      // their guid-ordering to be deterministic
      let jaimeInDisguise = {
        fname: 'Cersei',
        lname: 'Lannister',
        age: 34,
      };

      let jaime = {
        fname: 'Jaime',
        lname: 'Lannister',
        age: 34,
      };

      let items = obj.get('items');

      items.replace(0, 1, [jaime]);
      items.replace(1, 1, [jaimeInDisguise]);

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'precond - array is initially sorted'
      );

      set(jaimeInDisguise, 'fname', 'Jaime');

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Jaime', 'Jaime', 'Bran', 'Robb'],
        'sorted array is updated'
      );

      set(jaimeInDisguise, 'fname', 'Cersei');

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'sorted array is updated'
      );
    }

    ['@test guid sort-order fallback with a search proxy is not confused by non-search ObjectProxys'](
      assert
    ) {
      let tyrion = {
        fname: 'Tyrion',
        lname: 'Lannister',
      };

      let tyrionInDisguise = ObjectProxy.create({
        fname: 'Yollo',
        lname: '',
        content: tyrion,
      });

      let items = obj.get('items');

      items.pushObject(tyrion);

      assert.deepEqual(obj.get('sortedItems').mapBy('fname'), [
        'Cersei',
        'Jaime',
        'Tyrion',
        'Bran',
        'Robb',
      ]);

      items.pushObject(tyrionInDisguise);

      assert.deepEqual(obj.get('sortedItems').mapBy('fname'), [
        'Yollo',
        'Cersei',
        'Jaime',
        'Tyrion',
        'Bran',
        'Robb',
      ]);
    }

    ['@test changing item properties specified via @each triggers a resort of the modified item'](
      assert
    ) {
      let items = get(obj, 'items');

      let tyrionInDisguise = items[1];

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'precond - array is initially sorted'
      );

      set(tyrionInDisguise, 'fname', 'Tyrion');

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Jaime', 'Tyrion', 'Bran', 'Robb'],
        'updating a specified property on an item resorts it'
      );
    }

    ['@test sort updates if additional dependent keys are present'](assert) {
      obj = EmberObject.extend({
        sortedItems: sort('items', ['sortFunction'], function() {
          return this.sortFunction(...arguments);
        }),
      }).create({
        sortFunction: sortByLnameFname,
        items: emberA([
          { fname: 'Jaime', lname: 'Lannister', age: 34 },
          { fname: 'Cersei', lname: 'Lannister', age: 34 },
          { fname: 'Robb', lname: 'Stark', age: 16 },
          { fname: 'Bran', lname: 'Stark', age: 8 },
        ]),
      });

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Cersei', 'Jaime', 'Bran', 'Robb'],
        'array is initially sorted'
      );

      obj.set('sortFunction', (a, b) => {
        if (a.age > b.age) {
          return -1;
        } else if (a.age < b.age) {
          return 1;
        }

        return 0;
      });

      assert.deepEqual(
        obj.get('sortedItems').mapBy('fname'),
        ['Jaime', 'Cersei', 'Robb', 'Bran'],
        'array is updated when dependent key changes'
      );
    }

    ['@test it throws on bad inputs']() {
      expectAssertion(() => {
        sort('foo', 'bar', 'baz');
      }, /`computed.sort` can either be used with an array of sort properties or with a sort function/);

      expectAssertion(() => {
        sort('foo', ['bar'], 'baz');
      }, /`computed.sort` can either be used with an array of sort properties or with a sort function/);

      expectAssertion(() => {
        sort('foo', 'bar', function() {});
      }, /`computed.sort` can either be used with an array of sort properties or with a sort function/);

      expectAssertion(() => {
        sort('foo', ['bar'], function() {}, 'baz');
      }, /`computed.sort` can either be used with an array of sort properties or with a sort function/);
    }
  }
);

moduleFor(
  'sort - stability',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        sortProps: ['count', 'name'],
        sortedItems: sort('items', 'sortProps'),
      }).create({
        items: [
          { name: 'A', count: 1, thing: 4 },
          { name: 'B', count: 1, thing: 3 },
          { name: 'C', count: 1, thing: 2 },
          { name: 'D', count: 1, thing: 4 },
        ],
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test sorts correctly as only one property changes'](assert) {
      assert.deepEqual(obj.get('sortedItems').mapBy('name'), ['A', 'B', 'C', 'D'], 'initial');

      set(obj.get('items')[3], 'count', 2);

      assert.deepEqual(obj.get('sortedItems').mapBy('name'), ['A', 'B', 'C', 'D'], 'final');
    }
  }
);

let klass;
moduleFor(
  'sort - concurrency',
  class extends AbstractTestCase {
    beforeEach() {
      klass = EmberObject.extend({
        sortProps: ['count'],
        sortedItems: sort('items', 'sortProps'),
        customSortedItems: sort('items.@each.count', (a, b) => a.count - b.count),
      });
      obj = klass.create({
        items: emberA([
          { name: 'A', count: 1, thing: 4, id: 1 },
          { name: 'B', count: 2, thing: 3, id: 2 },
          { name: 'C', count: 3, thing: 2, id: 3 },
          { name: 'D', count: 4, thing: 1, id: 4 },
        ]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test sorts correctly after mutation to the sort properties'](assert) {
      let sorted = obj.get('sortedItems');
      assert.deepEqual(sorted.mapBy('name'), ['A', 'B', 'C', 'D'], 'initial');

      set(obj.get('items')[1], 'count', 5);
      set(obj.get('items')[2], 'count', 6);

      assert.deepEqual(obj.get('sortedItems').mapBy('name'), ['A', 'D', 'B', 'C'], 'final');
    }

    ['@test sort correctly after mutation to the sort'](assert) {
      assert.deepEqual(obj.get('customSortedItems').mapBy('name'), ['A', 'B', 'C', 'D'], 'initial');

      set(obj.get('items')[1], 'count', 5);
      set(obj.get('items')[2], 'count', 6);

      assert.deepEqual(obj.get('customSortedItems').mapBy('name'), ['A', 'D', 'B', 'C'], 'final');

      assert.deepEqual(obj.get('sortedItems').mapBy('name'), ['A', 'D', 'B', 'C'], 'final');
    }

    ['@test sort correctly on multiple instances of the same class'](assert) {
      let obj2 = klass.create({
        items: emberA([
          { name: 'W', count: 23, thing: 4 },
          { name: 'X', count: 24, thing: 3 },
          { name: 'Y', count: 25, thing: 2 },
          { name: 'Z', count: 26, thing: 1 },
        ]),
      });

      assert.deepEqual(obj2.get('sortedItems').mapBy('name'), ['W', 'X', 'Y', 'Z'], 'initial');
      assert.deepEqual(obj.get('sortedItems').mapBy('name'), ['A', 'B', 'C', 'D'], 'initial');

      set(obj.get('items')[1], 'count', 5);
      set(obj.get('items')[2], 'count', 6);
      set(obj2.get('items')[1], 'count', 27);
      set(obj2.get('items')[2], 'count', 28);

      assert.deepEqual(obj.get('sortedItems').mapBy('name'), ['A', 'D', 'B', 'C'], 'final');
      assert.deepEqual(obj2.get('sortedItems').mapBy('name'), ['W', 'Z', 'X', 'Y'], 'final');

      obj.set('sortProps', ['thing']);

      assert.deepEqual(obj.get('sortedItems').mapBy('name'), ['D', 'C', 'B', 'A'], 'final');

      obj2.notifyPropertyChange('sortedItems'); // invalidate to flush, to get DK refreshed
      obj2.get('sortedItems'); // flush to get updated DK

      obj2.set('items.firstObject.count', 9999);

      assert.deepEqual(obj2.get('sortedItems').mapBy('name'), ['Z', 'X', 'Y', 'W'], 'final');
    }

    ['@test sort correctly when multiple sorts are chained on the same instance of a class'](
      assert
    ) {
      let obj2 = klass
        .extend({
          items: computed('sibling.sortedItems.[]', function() {
            return this.get('sibling.sortedItems');
          }),
          asdf: observer('sibling.sortedItems.[]', function() {
            this.get('sibling.sortedItems');
          }),
        })
        .create({
          sibling: obj,
        });

      /*
                                             ┌───────────┐                              ┌────────────┐
                                             │sortedProps│                              │sortedProps2│
                                             └───────────┘                              └────────────┘
                                                   ▲                                           ▲
                                                   │               ╔═══════════╗               │
                                                   │─ ─ ─ ─ ─ ─ ─ ▶║ CP (sort) ║◀─ ─ ─ ─ ─ ─ ─ ┤
                                                   │               ╚═══════════╝               │
                                                   │                                           │
    ┌───────────┐                            ┏━━━━━━━━━━━┓                              ┏━━━━━━━━━━━━┓
    │           │   ┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─    ┃           ┃    ┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─     ┃            ┃
    │   items   │◀──  items.@each.count  │◀──┃sortedItems┃◀───  items.@each.count  │◀───┃sortedItems2┃
    │           │   └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─    ┃           ┃    └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─     ┃            ┃
    └───────────┘                            ┗━━━━━━━━━━━┛                              ┗━━━━━━━━━━━━┛
    */

      assert.deepEqual(
        obj.get('sortedItems').mapBy('name'),
        ['A', 'B', 'C', 'D'],
        'obj.sortedItems.name should be sorted alpha'
      );
      assert.deepEqual(
        obj2.get('sortedItems').mapBy('name'),
        ['A', 'B', 'C', 'D'],
        'obj2.sortedItems.name should be sorted alpha'
      );

      set(obj.get('items')[1], 'count', 5);
      set(obj.get('items')[2], 'count', 6);

      assert.deepEqual(
        obj.get('sortedItems').mapBy('name'),
        ['A', 'D', 'B', 'C'],
        'obj.sortedItems.name should now have changed'
      );
      assert.deepEqual(
        obj2.get('sortedItems').mapBy('name'),
        ['A', 'D', 'B', 'C'],
        'obj2.sortedItems.name should still mirror sortedItems2'
      );

      obj.set('sortProps', ['thing']);
      obj2.set('sortProps', ['id']);

      assert.deepEqual(
        obj2.get('sortedItems').mapBy('name'),
        ['A', 'B', 'C', 'D'],
        'we now sort obj2 by id, so we expect a b c d'
      );
      assert.deepEqual(
        obj.get('sortedItems').mapBy('name'),
        ['D', 'C', 'B', 'A'],
        'we now sort obj by thing'
      );

      obj2.destroy();
    }
  }
);

moduleFor(
  'max',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        max: max('items'),
      }).create({
        items: emberA([1, 2, 3]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test max is readOnly'](assert) {
      assert.throws(function() {
        obj.set('max', 1);
      }, /Cannot set read-only property "max" on object:/);
    }

    ['@test max tracks the max number as objects are added'](assert) {
      assert.equal(obj.get('max'), 3, 'precond - max is initially correct');

      let items = obj.get('items');

      items.pushObject(5);

      assert.equal(obj.get('max'), 5, 'max updates when a larger number is added');

      items.pushObject(2);

      assert.equal(obj.get('max'), 5, 'max does not update when a smaller number is added');
    }

    ['@test max recomputes when the current max is removed'](assert) {
      assert.equal(obj.get('max'), 3, 'precond - max is initially correct');

      obj.get('items').removeObject(2);

      assert.equal(obj.get('max'), 3, 'max is unchanged when a non-max item is removed');

      obj.get('items').removeObject(3);

      assert.equal(obj.get('max'), 1, 'max is recomputed when the current max is removed');
    }
  }
);

moduleFor(
  'min',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        min: min('items'),
      }).create({
        items: emberA([1, 2, 3]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test min is readOnly'](assert) {
      assert.throws(function() {
        obj.set('min', 1);
      }, /Cannot set read-only property "min" on object:/);
    }

    ['@test min tracks the min number as objects are added'](assert) {
      assert.equal(obj.get('min'), 1, 'precond - min is initially correct');

      obj.get('items').pushObject(-2);

      assert.equal(obj.get('min'), -2, 'min updates when a smaller number is added');

      obj.get('items').pushObject(2);

      assert.equal(obj.get('min'), -2, 'min does not update when a larger number is added');
    }

    ['@test min recomputes when the current min is removed'](assert) {
      let items = obj.get('items');

      assert.equal(obj.get('min'), 1, 'precond - min is initially correct');

      items.removeObject(2);

      assert.equal(obj.get('min'), 1, 'min is unchanged when a non-min item is removed');

      items.removeObject(1);

      assert.equal(obj.get('min'), 3, 'min is recomputed when the current min is removed');
    }
  }
);

moduleFor(
  'Ember.arrayComputed - mixed sugar',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        lannisters: filterBy('items', 'lname', 'Lannister'),
        lannisterSorting: emberA(['fname']),
        sortedLannisters: sort('lannisters', 'lannisterSorting'),

        starks: filterBy('items', 'lname', 'Stark'),
        starkAges: mapBy('starks', 'age'),
        oldestStarkAge: max('starkAges'),
      }).create({
        items: emberA([
          { fname: 'Jaime', lname: 'Lannister', age: 34 },
          { fname: 'Cersei', lname: 'Lannister', age: 34 },
          { fname: 'Robb', lname: 'Stark', age: 16 },
          { fname: 'Bran', lname: 'Stark', age: 8 },
        ]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test filtering and sorting can be combined'](assert) {
      let items = obj.get('items');

      assert.deepEqual(
        obj.get('sortedLannisters').mapBy('fname'),
        ['Cersei', 'Jaime'],
        'precond - array is initially filtered and sorted'
      );

      items.pushObject({ fname: 'Tywin', lname: 'Lannister' });
      items.pushObject({ fname: 'Lyanna', lname: 'Stark' });
      items.pushObject({ fname: 'Gerion', lname: 'Lannister' });

      assert.deepEqual(
        obj.get('sortedLannisters').mapBy('fname'),
        ['Cersei', 'Gerion', 'Jaime', 'Tywin'],
        'updates propagate to array'
      );
    }

    ['@test filtering, sorting and reduce (max) can be combined'](assert) {
      let items = obj.get('items');

      assert.equal(16, obj.get('oldestStarkAge'), 'precond - end of chain is initially correct');

      items.pushObject({ fname: 'Rickon', lname: 'Stark', age: 5 });

      assert.equal(16, obj.get('oldestStarkAge'), 'chain is updated correctly');

      items.pushObject({ fname: 'Eddard', lname: 'Stark', age: 35 });

      assert.equal(35, obj.get('oldestStarkAge'), 'chain is updated correctly');
    }
  }
);

function todo(name, priority) {
  return EmberObject.create({ name: name, priority: priority });
}

function priorityComparator(todoA, todoB) {
  let pa = parseInt(get(todoA, 'priority'), 10);
  let pb = parseInt(get(todoB, 'priority'), 10);

  return pa - pb;
}

function evenPriorities(todo) {
  let p = parseInt(get(todo, 'priority'), 10);

  return p % 2 === 0;
}

moduleFor(
  'Ember.arrayComputed - chains',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        sorted: sort('todos.@each.priority', priorityComparator),
        filtered: filter('sorted.@each.priority', evenPriorities),
      }).create({
        todos: emberA([todo('E', 4), todo('D', 3), todo('C', 2), todo('B', 1), todo('A', 0)]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test it can filter and sort when both depend on the same item property'](assert) {
      assert.deepEqual(
        obj.get('todos').mapBy('name'),
        ['E', 'D', 'C', 'B', 'A'],
        'precond - todos initially correct'
      );
      assert.deepEqual(
        obj.get('sorted').mapBy('name'),
        ['A', 'B', 'C', 'D', 'E'],
        'precond - sorted initially correct'
      );
      assert.deepEqual(
        obj.get('filtered').mapBy('name'),
        ['A', 'C', 'E'],
        'precond - filtered initially correct'
      );

      set(obj.get('todos')[1], 'priority', 6);

      assert.deepEqual(
        obj.get('todos').mapBy('name'),
        ['E', 'D', 'C', 'B', 'A'],
        'precond - todos remain correct'
      );
      assert.deepEqual(
        obj.get('sorted').mapBy('name'),
        ['A', 'B', 'C', 'E', 'D'],
        'precond - sorted updated correctly'
      );
      assert.deepEqual(
        obj.get('filtered').mapBy('name'),
        ['A', 'C', 'E', 'D'],
        'filtered updated correctly'
      );
    }
  }
);

let userFnCalls;
moduleFor(
  'Chaining array and reduced CPs',
  class extends AbstractTestCase {
    beforeEach() {
      userFnCalls = 0;
      obj = EmberObject.extend({
        mapped: mapBy('array', 'v'),
        max: max('mapped'),
        maxDidChange: observer('max', () => userFnCalls++),
      }).create({
        array: emberA([{ v: 1 }, { v: 3 }, { v: 2 }, { v: 1 }]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    async ['@test it computes interdependent array computed properties'](assert) {
      assert.equal(obj.get('max'), 3, 'sanity - it properly computes the maximum value');

      let calls = 0;

      addObserver(obj, 'max', () => calls++);

      obj.get('array').pushObject({ v: 5 });
      await runLoopSettled();

      assert.equal(obj.get('max'), 5, 'maximum value is updated correctly');
      assert.equal(userFnCalls, 1, 'object defined observers fire');
      assert.equal(calls, 1, 'runtime created observers fire');
    }
  }
);

moduleFor(
  'sum',
  class extends AbstractTestCase {
    beforeEach() {
      obj = EmberObject.extend({
        total: sum('array'),
      }).create({
        array: emberA([1, 2, 3]),
      });
    }

    afterEach() {
      run(obj, 'destroy');
    }

    ['@test sum is readOnly'](assert) {
      assert.throws(function() {
        obj.set('total', 1);
      }, /Cannot set read-only property "total" on object:/);
    }

    ['@test sums the values in the dependentKey'](assert) {
      assert.equal(obj.get('total'), 6, 'sums the values');
    }

    ['@test if the dependentKey is neither an array nor object, it will return `0`'](assert) {
      set(obj, 'array', null);
      assert.equal(get(obj, 'total'), 0, 'returns 0');

      set(obj, 'array', undefined);
      assert.equal(get(obj, 'total'), 0, 'returns 0');

      set(obj, 'array', 'not an array');
      assert.equal(get(obj, 'total'), 0, 'returns 0');
    }

    ['@test updates when array is modified'](assert) {
      obj.get('array').pushObject(1);

      assert.equal(obj.get('total'), 7, 'recomputed when elements are added');

      obj.get('array').popObject();

      assert.equal(obj.get('total'), 6, 'recomputes when elements are removed');
    }
  }
);

moduleFor(
  'collect',
  class extends AbstractTestCase {
    ['@test works'](assert) {
      let obj = { one: 'foo', two: 'bar', three: null };
      defineProperty(obj, 'all', collect('one', 'two', 'three', 'four'));

      assert.deepEqual(get(obj, 'all'), ['foo', 'bar', null, null], 'have all of them');

      set(obj, 'four', true);

      assert.deepEqual(get(obj, 'all'), ['foo', 'bar', null, true], 'have all of them');

      let a = [];
      set(obj, 'one', 0);
      set(obj, 'three', a);

      assert.deepEqual(get(obj, 'all'), [0, 'bar', a, true], 'have all of them');
    }
  }
);