a skip before test fails when this.subject() is called in beforeEach

[amiel]

I have a reproduction example at amiel/qunit-skip-example (this test shows the specific case).

I'm happy to look in to this further, but wanted to start by reporting the issue.

Does anyone know off-hand what the issue is?

Use Case

We frequently use this.subject() in beforeEach to set attributes on the subject that all tests share.

Normally this hasn't caused any issues, even when using skip, but we ran in to an exception when skip happened to be the first test.

Details

The first exception is:

beforeEach failed on it exists: undefined is not an object (evaluating 'module.setContext')

Which happens in qunit-module.js (in beforeEach). This is why I reported the bug here, but I'm not sure if it could be a symptom of an issue with qunit.

[rwjblue]

This sounds suspicious similar to #268 (comment) which was fixed upstream in qunitjs/qunit#1156...

[amiel]

@rwjblue wow, incredible timing. I can test my example project with an updated qunit once there's a release.

Should we leave this issue open until ember-cli-qunit can update its dependency on qunit to include the fix?

[trentmwillis]

A fresh npm install should resolve this as [email protected] is now released. Please reopen if it persists.

[amiel]

@trentmwillis, @rwjblue: example tests pass with [email protected]. Thank you very much 🍻