Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests with components and new life-cycle hooks #174

Closed
thec0keman opened this issue Jun 17, 2015 · 4 comments
Closed

Unit tests with components and new life-cycle hooks #174

thec0keman opened this issue Jun 17, 2015 · 4 comments

Comments

@thec0keman
Copy link

Not sure if this is the right place to mention this, but with components in 1.13 some of the lifecycle hooks are not being called. The issue is we have a few tests that are failing because the willRender hook is not being called. Manually calling this from within the test solves the issue, as is changing the hook to didInsertElement.

Is this expected behavior, or should part of the test setup for components also fire off some of the initial lifecycle hooks?

@mmahalwy
Copy link

Any luck with this @thec0keman

@thec0keman
Copy link
Author

For now I've just been manually calling them in tests when needed. 😞

@mmahalwy
Copy link

Yeah me too +1

@thec0keman
Copy link
Author

After watching this recent discussion on migrating to 2.0 I now realize that this is an inherent limitation of unit component tests. Integration component tests resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants