Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:enable, feature:disable commands update the optional-fatures.js file thus replacing existing key:value with new ones. May want to append to the file, rather than replace/update. #134

Closed
AvinishSharma opened this issue Sep 24, 2019 · 3 comments
Assignees

Comments

@AvinishSharma
Copy link

Each time this one of feature:enable, feature:disable commands is executed, optional-features.js file is updated (existing key: value in the file are replaced with the new one) not appended. This caused a bit of a heartache for me as it put me in a loop for a bit. 🙂 I had to manually edit the file and the key:values to the object inside it.

@rwjblue
Copy link
Member

rwjblue commented Sep 26, 2019

Thanks for reporting! I'm going to look into this later today...

@rwjblue rwjblue self-assigned this Sep 26, 2019
@simonihmig
Copy link
Contributor

@AvinishSharma Is this in an addon, or using a custom config path? If so, sounds like a duplicate of #74!?

@rwjblue
Copy link
Member

rwjblue commented Dec 16, 2019

I think this is resolved now (thanks @simonihmig!).

@rwjblue rwjblue closed this as completed Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants