ember-data 2.14.0: DS.AdapterError.extend no longer working

[urbany]

The following code was working on [email protected]

import DS from 'ember-data';

export default DS.AdapterError.extend({ message: 'Down for maintenance.' });

I got this from: https://emberjs.com/api/data/classes/DS.AdapterError.html (at the time of this posting the docs are still pointing to TAG: V2.13.0)

And now with [email protected] I get the following error:
TypeError: _emberData.default.AdapterError.extend is not a function

[lucacorti]

I get the same error on 2.14.1, same use case.

import { AdapterError } from 'ember-data/adapters/errors';

export default AdapterError.extend({
[...]
});

[runspired]

I suspect this is simply another manifestation of #5022 (and #5021 and #5019 )

[urbany]

@runspired I just tried version 2.14.2 and I got the same error as before: TypeError: _emberData.default.AdapterError.extend is not a function

[runspired]

@urbany tracked this down to the extend is not a function unless the feature flag is configured for it to be on, you likely need to configure it. We may have been improperly failing to strip the feature in the past.

[urbany]

Ah, thanks @runspired I thought it might be that, but checked the features flag and the default is TRUE, shouldn't it work by default in this case? https://github.com/emberjs/data/blob/v2.14.2/config/features.json

Maybe the docs about the AdapterError should reflect that it is behind a feature flag. https://emberjs.com/api/data/classes/DS.AdapterError.html

[lucacorti]

I think @urbany is right. The release post for 2.13 also states that ds-extendend-errors is now enabled: https://www.emberjs.com/blog/2017/04/29/ember-2-13-released.html

[runspired]

cc @rwjblue this is looking like an issue with the early defeaturify work.

[rwjblue]

kk, I'll try to dig into it this afternoon

[urbany]

Hi, sorry to bother you @rwjblue but have you managed to check this? It's preventing us from upgrading to 2.14
Thanks in advance!

[sihuang]

I encountered the same issue with 2.13 and have been holding off upgrade since. @rwjblue help much needed. Thanks in advance.

[urbany]

Just a small update:

If I add this to my config/environment.js

EmberENV.FEATURES['ds-extended-errors'] = true;

It seems to work. Since this feature is supposed to be ON by default there is still a bug here, but if anyone want to start using 2.14 before this is fixed, the code absove should get you going.

Unfortunately I found another bug that is preventing me from upgrading so I'll keep on 2.13 for now.

[sihuang]

@urbany Thanks for your update. I can certainly use this workaround for the time being.

[tinyweasel]

This doesn't work for me on 2.13 or 2.14 and I can't use the canary build, is there a proper fix planned?

[acorncom]

@tinyweasel a number of bugs made there way in in 2.13 as part of refactored done. They are being ironed out, but Ember Data is complicated ...

Looks like there is a pending fix here: #5107

[pangratz]

Looks like there is a pending fix here: #5107

For further context, the rebased PR is at #5191

[pangratz]

Closing as this has been fixed in #5191