Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model blueprint is using old DS style imports, causes deprecation warnings #4951

Closed
adhamhf opened this issue Apr 27, 2017 · 5 comments
Closed

model blueprint is using old DS style imports, causes deprecation warnings #4951

adhamhf opened this issue Apr 27, 2017 · 5 comments

Comments

@adhamhf
Copy link

adhamhf commented Apr 27, 2017

Hi,

I found this PR: #4481

It doesn't seem to make since though, using this old style import causes deprecation warnings which makes people have to manually change to the new style syntax.

Why not have the blueprint use the new syntax?
@stefanpenner
Copy link
Member

@bmac can you take a look?

@bmac
Copy link
Member

bmac commented Apr 27, 2017

I'll check it out tomorrow when I get some free time.

@locks
Copy link
Contributor

locks commented Apr 30, 2017

@adhamhf can you post some of these deprecation warnings?

@adhamhf
Copy link
Author

adhamhf commented May 2, 2017

@locks its these:
https://emberjs.com/deprecations/ember-data/v2.x/#toc_global-version-of-ds

@runspired
Copy link
Contributor

Blueprints are updated to the latest ember-qunit with modern test helper usage :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stefanpenner @locks @bmac @runspired @adhamhf