Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built version of ember-data published to cdnjs.com does not compile. #4873

Closed
Gaurav0 opened this issue Mar 16, 2017 · 4 comments
Closed

Built version of ember-data published to cdnjs.com does not compile. #4873

Gaurav0 opened this issue Mar 16, 2017 · 4 comments

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Mar 16, 2017

This version: https://cdnjs.cloudflare.com/ajax/libs/ember-data.js/2.12.0/ember-data.js of Ember Data does not compile.

See https://ember-twiddle.com/f3c647c9c4ef70c46d2dbe3aeabc5c72?openFiles=twiddle.json%2C

This is the version currently used by Ember Twiddle when a specific version is specified.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Mar 16, 2017

Please note also that the "release" version at builds.emberjs.com is still 2.11.3

@runspired
Copy link
Contributor

https://github.com/emberjs/data/blob/master/lib/javascripts.js#L55

^ this line closing out the iife that wraps the globals build needs to pass in this or window as the context.

@bmac
Copy link
Member

bmac commented Mar 17, 2017

Ember Data 2.12.1 has been published with a fix for this issue. Please let me know if you are still experiencing issues.

@bmac
Copy link
Member

bmac commented Mar 18, 2017

@runspired reports that 2.12.1 has fixed the issue with Ember Twiddle. I'm going to close this issue. Feel free to reopen if there is still a problem.

@bmac bmac closed this as completed Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants