-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert when ManyArray.objectAt after one of the records has been unloaded #4758
Comments
Fixed in #4896 |
Additional fix in #4912 |
#4896 does not appear fix this issue, I believe #4896 is actually performing the wrong check. Out of bounds access does not signify an unloaded record, rather it is just out of bounds access and should return undefined (no warning). Rather the check here should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Although it would be nice for this to work, we do not support sparse arrays. It would probably be better to error rather than to have undefined behaviour (as we have today).
However, it is likely better as a first step to just warn, and then to see how pervasive the warning becomes, especially in test teardown.
The text was updated successfully, but these errors were encountered: