DS.Errors#add/remove/clear should not be marked as deprecated?

[HeroicEric]

As a result of #3853, DS.Errors#add, DS.Errors#remove, and DS.Errors#clear were marked as deprecated but no deprecation was added to the functions. Instead, a warning was added to the functions to make sure the behavior was clear.

I think we need to either

• add deprecations to these functions
• remove the @deprecated tags

[runspired]

We discussed this recently and I believe we do want to move to deprecate, possibly even go all the way to assertion.

After reading through the code it appears as though the warning was meant to be a partial behavior deprecation for something we intended to change in 3.0; however, we never changed it in 3.0. We partially removed the deprecated Evented functionality in 3.4 but looking back I think we didn't quite finish the job, will submit a follow up PR and clean this up.

[runspired]

Closing as we decided to not pursue a deprecation at this time. The RecordData Errors RFC will provide an alternative path to a future without this class.