Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record.updateRecordArrays called for addRecord not removeRecord #4646

Closed
stefanpenner opened this issue Nov 11, 2016 · 1 comment
Closed

record.updateRecordArrays called for addRecord not removeRecord #4646

stefanpenner opened this issue Nov 11, 2016 · 1 comment
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@stefanpenner
Copy link
Member

stefanpenner commented Nov 11, 2016 •
edited
Loading

https://github.com/emberjs/data/blob/master/addon/-private/system/relationships/state/relationship.js#L177

Seems like it should actually just be called when in a less specific place.
@stefanpenner stefanpenner mentioned this issue Nov 11, 2016
Merged
@runspired
Copy link
Contributor

Unfortunately the line of code has drifted. That said, I believe we have resolved this recently: I discovered this sort of bug when adding new tests for #5438

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanpenner @runspired