Can't return null to queryRecord anymore

[danconnell]

Previously on Ember Data 2.3.3, you could have you API return null to a call made by queryRecord. Now, on Ember Data 2.4.3, you get this error if you try to do that:

Assertion Failed: You made aqueryRecordrequest for undefinedrecords, with query[object Object], but the adapter's response did not have any data Error: Assertion Failed: You made aqueryRecordrequest for undefinedrecords, with query[object Object], but the adapter's response did not have any data

Was this an intended change? I understand that this might not be a bug, but I also don't see this change mentioned in the changelog.

Just thought I should point it out, since it did break something for me.

[pangratz]

Thanks for reporting this @danconnell. What adapter are you using? Can you provide an ember-twiddle, demonstrating the issue? You can use this twiddle as a start, it uses the json-api adapter. Thanks!

[pangratz]

Ah now I can reproduce the issue you're having. I had it wrong, and in the twiddle { data: null } is returned which is not the same thing you return I assume.

---

The issue you're having has been fixed in #4256, which is available in 2.5.0-beta.3. Can you try out that version and confirm that your app is working again? Edit: the linked issue #4256 is unrelated to this one here.

[danconnell]

I'm using the rest adapter.

Tested on 2.5.0-beta.3 and it's still broken. Here's a twiddle using 2.5.0-beta.3.

[pangratz]

Looks like this is a regression. There is no assert throwing in v2.3.3 but in v2.4.3 there is.

The assertion has been added in #3916, because at that time a not very descriptive error You must include an 'id' for undefined in an object passed to 'push' would be thrown if the payload was empty. Maybe this is already better handled in the meantime...

[pangratz]

This has been discussed in the team meeting and the assertion for queryRecord should be removed and the old behavior should be restored. This will be tackled in the course of #4300.

[danconnell]

Sounds good. Thanks for the update :)

[BissyQA]

same error Assertion Failed: You made a queryRecord request for undefinedrecords, with query `[object Object]. Does the issue fixed in 4300? . Is this alternate way to fix the error ?

because at that time a not very descriptive error You must include an 'id' for undefined in an object passed to 'push' would be thrown if the payload was empty.

[pangratz]

@BissyQA yes, this is addressed in #4300. Until the PR is merged and a new release is cut, you can work around this by ensuring that you don't return an empty object as payload from the adapter, as shown in this ember-twiddle:

import DS from "ember-data";

export default DS.RESTAdapter.extend({
  queryRecord() {
    return this._super(...arguments).then(function(payload) {
      // workaround so returned payload is not empty, remove
      // once https://github.com/emberjs/data/pull/4300
      // is merged and released
      payload._unusedKeySoPayloadIsNotEmpty = {};

      return payload;
    });
  }
});

[pangratz]

I am going to close this issue since #4300 has been merged and the regression has been fixed in that PR.