Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: confusing deprecated mentions of isDirty #3823

Closed
James1x0 opened this issue Oct 6, 2015 · 0 comments · Fixed by #3827
Closed

Docs: confusing deprecated mentions of isDirty #3823

James1x0 opened this issue Oct 6, 2015 · 0 comments · Fixed by #3827

Comments

@James1x0
Copy link
Contributor

James1x0 commented Oct 6, 2015

There are lots of mentions to the deprecated isDirty model flag (replaced with hasDirtyAttributes).
http://emberjs.com/blog/2015/06/18/ember-data-1-13-released.html#toc_code-isdirty-code-renamed-to-code-hasdirtyattributes-code
https://github.com/emberjs/data/blob/v2.1.0/packages/ember-data/lib/system/model/model.js#L119-L121

There are more mentions than I have time to edit:
https://github.com/emberjs/data/blob/v2.1.0/packages/ember-data/lib/system/model/model.js#L162
https://github.com/emberjs/data/blob/v2.1.0/packages/ember-data/lib/system/model/model.js#L174
https://github.com/emberjs/data/blob/v2.1.0/packages/ember-data/lib/system/model/model.js#L648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DOC] Remove reference to isDirty in DS.Model documentation
1 participant
@James1x0