Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add findByRecord and deprecate findById #3228

Closed
bmac opened this issue Jun 6, 2015 · 4 comments · Fixed by #3232 or #3241
Closed

Add findByRecord and deprecate findById #3228

bmac opened this issue Jun 6, 2015 · 4 comments · Fixed by #3232 or #3241

Comments

@bmac
Copy link
Member

bmac commented Jun 6, 2015

Rename findById to findByRecord. Update all internal references of findById to findByRecord.

Add a new findById method that logs a deprecation warning then delegates to findByRecord.

@igorT
Copy link
Member

igorT commented Jun 6, 2015

emberjs/rfcs#27 (comment) calls it findRecord and not findByRecord ?

@HeroicEric
Copy link
Member

@igorT I believe those are to be two separate methods (findByRecord and findRecord).

I asked @bmac about the differences earlier in slack and he said "findByRecord does some extra bookkeeping and should be private"

@igorT
Copy link
Member

igorT commented Jun 7, 2015

Ah is this just an internal cleanup?

@bmac
Copy link
Member Author

bmac commented Jun 7, 2015

Oops this should have been findRecord. My mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants