Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the polyfill when the feature is available in ember-source #1

Closed
Windvis opened this issue Mar 19, 2021 · 2 comments · Fixed by #10
Closed

Disable the polyfill when the feature is available in ember-source #1

Windvis opened this issue Mar 19, 2021 · 2 comments · Fixed by #10

Comments

@Windvis
Copy link
Collaborator

Windvis commented Mar 19, 2021

Once the upstream PR is merged we know the version for which the polyfill needs to be disabled.

The polyfill should be removed from the final build of all projects that have this version and a warning should be shown in the console that the polyfill can be safely removed.

@musaffa
Copy link

musaffa commented Mar 29, 2021

Also consider moving it to ember-polyfills.

@Windvis
Copy link
Collaborator Author

Windvis commented Mar 29, 2021

@musaffa Yes, for sure! Once the PR is merged I will finish up this addon and ask around to get it moved to the ember-polyfill organisation.

@Windvis Windvis changed the title Make it possible to disable the polyfill based on an Ember version Disable the polyfill when the feature is available in ember-source Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants