Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable polyfill for Ember 3.11 #50

Closed
buschtoens opened this issue Apr 27, 2019 · 0 comments · Fixed by #57
Closed

Disable polyfill for Ember 3.11 #50

buschtoens opened this issue Apr 27, 2019 · 0 comments · Fixed by #57
Labels
build

Comments

@buschtoens
Copy link
Collaborator

buschtoens commented Apr 27, 2019 •
edited
Loading

Sub-task of #45 (comment):

Use ember-cli-version-checker's .forEmber() to check if we are using >= 3.11.0-beta.1

  • if we are on 3.11+ disable treeForAddon
  • if we are on < 3.11, do normal processing

Should also print a warning in the CLI, if ember-on-modifier is a direct dependency, so that the user is aware and can uninstall ember-on-modifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: making ember-on-modifier a true polyfill gmurphey/ember-on-modifier
1 participant
@buschtoens