Warning message shown in ember-try scenarios

[Turbo87]

I'm seeing

ember-getowner-polyfill is not required for Ember 2.3.0 and later,
please remove from your `package.json`.

when testing some addons via ember-try. These addons are compatible down to v1.13/2.0 which obviously requires the polyfill, but it is still warning when we test against more recent releases. Is there some way to disable the warning?

[rwjblue]

Nope, it should warn if used with a newer Ember version. This seems totally fine, and only a minor inconvenience.

[Turbo87]

I'm not sure I agree. Should all polyfills warn if used in newer environments where they're deactivated automatically? that seems a little strange.

[rwjblue]

The warning is primarily for apps, and yes you should absolutely remove ember-getowner-polyfill from your application's dependencies if you are using Ember 2.3+.

When an addon depends on ember-getowner-polyfill this warning is not shown to consumers of the addon (even if they are using Ember 2.3+). See this guard for how we prevent warnings in that scenario. This is simply a minor minor annoyance while developing the addon itself, and you can always use ember-try to remove the polyfill if it bothers you a bunch.

[Turbo87]

@rwjblue example of how this warning can be confusing: mainmatter/ember-simple-auth#1124 (comment)

[rwjblue]

Awesome, thanks for that link. I'll think on it to see how to make it better.

[Turbo87]

@rwjblue another one mainmatter/ember-simple-auth#1190 (comment) 😉

[rwjblue]

Going to close for now (so I can archive the repo), I do think we should generally find a better way to message this in polyfills.