Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETag cache is not reset during backup load command #339

Open
3 tasks
Syndesi opened this issue Oct 8, 2024 · 1 comment
Open
3 tasks

ETag cache is not reset during backup load command #339

Syndesi opened this issue Oct 8, 2024 · 1 comment
Labels
Bug Addressing unexpected issues.
Milestone

Comments

@Syndesi
Copy link
Member

Syndesi commented Oct 8, 2024

The backup load command expects an empty database, i.e. no nodes or relations, and then imports some data. While this does guarantee that no element data is present, cached ETags from previous usage can remain.

Tasks:

  • Clear ETags during backup load command.
  • Check if other cached data might need to be reset as well.
  • Optionally create a new command / function which can clear all cached data, and rebuild caches if required.
@Syndesi Syndesi added the Bug Addressing unexpected issues. label Oct 8, 2024
@Syndesi Syndesi added this to the 0.2.0 milestone Oct 8, 2024
@Syndesi
Copy link
Member Author

Syndesi commented Oct 8, 2024

Additional information: The endpoint GET / with no auth data, i.e. via anonymous access, is especially sensible to this bug, as the frequent healthcheck can result in generating an "empty ETag", which is then persisted within Redis, and not updated on further element updates.

The following tasks should be performed as well:

  • Make sure that the ETag cache is being cleared before any elements are loaded.
  • Do not generate new ETags until the whole backup is loaded. It might be also useful to block every API request while the backup is being loaded.
  • Make sure that the ETag cache is still empty after the backup import was successful.
  • Optional: Provide a new command to enable/disable API access easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing unexpected issues.
Projects
Status: No status
Development

No branches or pull requests

1 participant