Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the underline implementation #465

Open
mansona opened this issue Jul 6, 2023 · 3 comments
Open

Update the underline implementation #465

mansona opened this issue Jul 6, 2023 · 3 comments

Comments

@mansona
Copy link
Member

mansona commented Jul 6, 2023 •
edited
Loading

Right now we're using background to give us a custom underline implementation, but it looks like CSS has come a long way since we implemented this

We should seriously consider using more modern techniques such as this youtube short https://www.youtube.com/watch?v=9WarmW1S10U
@mansona mansona converted this from a draft issue Jul 6, 2023
@mansona mansona changed the title links (href) that are also code block have an overflow of the underline Update the underline implementation Jul 6, 2023
@taiwo2
Copy link

taiwo2 commented Oct 14, 2024

@mansona Can you please assign this issue to me

@mansona
Copy link
Member Author

mansona commented Oct 14, 2024

@taiwo2 sorry it's not possible to assign issues to people not in the ember-learn org, but if you want to try implementing it then feel free 👍

@taiwo2
Copy link

taiwo2 commented Oct 16, 2024

@mansona kindly review my PR#524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Redesign the Ember Guides
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mansona @taiwo2