Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastboot shows quick initial render, but then loading route shows when hydrating #149

Closed
toddjordan opened this issue Mar 15, 2017 · 14 comments · Fixed by #159
Closed

Fastboot shows quick initial render, but then loading route shows when hydrating #149

toddjordan opened this issue Mar 15, 2017 · 14 comments · Fixed by #159
Assignees
Milestone

Comments

@toddjordan
Copy link
Contributor

toddjordan commented Mar 15, 2017

Launch the app with ember fastboot --serve-assets

Observe the loading indicator after the initial render:
fastboot-issue

@toddjordan toddjordan added this to the MVP milestone Mar 15, 2017
@MartinMalinda
Copy link
Contributor

This is most likely because there is no shoeboxing via something like https://github.com/cardstack/ember-data-fastboot.
I'll try it out today if it can be easily fixed.

@MartinMalinda
Copy link
Contributor

ember-data-fastboot seems to not work with latest Ember-Data. I've sent a PR there: cardstack/ember-data-fastboot#9. Once this gets resolved, this can be solved by simple ember-data-fastboot install. I've tested it with my fork and the issue was gone.

@toddjordan
Copy link
Contributor Author

toddjordan commented Mar 15, 2017

nice. forgot to mention that I'm seeing this on siva's branch: #146 , which has the latest fastboot version.

@acorncom
Copy link
Member

Siva's branch has now been merged, so this should be happening on master

@acorncom
Copy link
Member

@MartinMalinda depending on how fast that PR gets merged, we're probably ok with depending on a fork too.

@MartinMalinda
Copy link
Contributor

@acorncom ok, I'll double check that it works with current master and send a PR

@MartinMalinda
Copy link
Contributor

MartinMalinda commented Mar 23, 2017

This issue should be reopened. My fork of ember-data-fastboot does not work for ember-resolver > 3.0.0.

We probably need to rollback Ember-resolver to 2.X for now.

Issue in ember-resolver is already reported: ember-cli/ember-resolver#175

@toddjordan toddjordan reopened this Mar 24, 2017
@toddjordan
Copy link
Contributor Author

doesn't seem to be happening on the prod instance at https://emberjs.com/api-new/

@MartinMalinda
Copy link
Contributor

The shoebox is empty so ember-data-fastboot is not working correctly there either:

<script type="fastboot/shoebox" id="shoebox-ember-data-store">{"records":{"data":[]}}</script>

Seems like there is no loading substate because the data is retreived from App Cache.

@MartinMalinda
Copy link
Contributor

This is fixed as of Ember-resolver 3.0.1, the caret in package.json should pick it up on next deploy. I checked it locally and shoebox works there.

@sivakumar-kailasam
Copy link
Member

sivakumar-kailasam commented Mar 24, 2017 via email

@MartinMalinda
Copy link
Contributor

Is this still true after 18ae79c?

@sivakumar-kailasam
Copy link
Member

@MartinMalinda nope the latest is deployed on staging. I don't see the issue, but may be others can confirm

@MartinMalinda
Copy link
Contributor

MartinMalinda commented Mar 25, 2017

Can confirm that the shoebox is working on staging right now 👍
screen shot 2017-03-25 at 09 08 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants