-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastboot shows quick initial render, but then loading route shows when hydrating #149
Comments
This is most likely because there is no shoeboxing via something like https://github.com/cardstack/ember-data-fastboot. |
ember-data-fastboot seems to not work with latest Ember-Data. I've sent a PR there: cardstack/ember-data-fastboot#9. Once this gets resolved, this can be solved by simple ember-data-fastboot install. I've tested it with my fork and the issue was gone. |
nice. forgot to mention that I'm seeing this on siva's branch: #146 , which has the latest fastboot version. |
Siva's branch has now been merged, so this should be happening on |
@MartinMalinda depending on how fast that PR gets merged, we're probably ok with depending on a fork too. |
@acorncom ok, I'll double check that it works with current master and send a PR |
This issue should be reopened. My fork of We probably need to rollback Ember-resolver to 2.X for now. Issue in ember-resolver is already reported: ember-cli/ember-resolver#175 |
doesn't seem to be happening on the prod instance at https://emberjs.com/api-new/ |
The shoebox is empty so ember-data-fastboot is not working correctly there either:
Seems like there is no loading substate because the data is retreived from App Cache. |
This is fixed as of Ember-resolver 3.0.1, the caret in package.json should pick it up on next deploy. I checked it locally and shoebox works there. |
We use yarn and heroku build pack uses yarn. So unsure if it will be picked
up
On Sat 25 Mar, 2017, 4:26 AM Martin Malinda, ***@***.***> wrote:
This is fixed as of Ember-resolver 3.0.1, the caret in package.json should
pick it up on next deploy. I checked it locally and shoebox works there.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAk31cahFjrckWYDTDZ7SYNtTxrBaEnnks5rpEo3gaJpZM4Mdeeq>
.
--
Regards,
Siva
|
Is this still true after 18ae79c? |
@MartinMalinda nope the latest is deployed on staging. I don't see the issue, but may be others can confirm |
Launch the app with
ember fastboot --serve-assets
Observe the loading indicator after the initial render:
The text was updated successfully, but these errors were encountered: