Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary package duplication #951

Open
ef4 opened this issue Sep 18, 2024 · 2 comments · May be fixed by #948
Open

Unnecessary package duplication #951

ef4 opened this issue Sep 18, 2024 · 2 comments · May be fixed by #948

Comments

@ef4
Copy link
Contributor

ef4 commented Sep 18, 2024

If you install ember-cli-fastboot 4.1.5, you will always get two different versions of fastboot in your dependency graph:

ember-cli-fastboot 4.1.5
├── fastboot 4.1.5
└─┬ fastboot-express-middleware 4.1.2
  └── fastboot 4.1.2

This is because workspace:* dependencies become exact version matches when published.

It would probably be better to use workspace:^.

@SergeAstapov
Copy link
Contributor

Related PR #948

i can update it with suggestion to use caret everywhere

@mansona
Copy link
Member

mansona commented Sep 19, 2024

@SergeAstapov yes if you update it to a ^ everywhere, I would merge that 👍

I wasn't confident enough to merge your other PR because I didn't have a real example of the effect, and Ed's example shows that we probably want to minimise the duplication 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants