Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip ember-cli-head usage test #393

Closed
kratiahuja opened this issue May 18, 2017 · 3 comments
Closed

Unskip ember-cli-head usage test #393

kratiahuja opened this issue May 18, 2017 · 3 comments

Comments

@kratiahuja
Copy link
Contributor

When #369 landed, we did not skipped the ember-cli-head addon tests in ember-cli-fastboot. This was because the addon requires to be updated per the fastboot migration guide. There is a PR in ember-cli-head when landed and released , we should skip the tests here

@mirague
Copy link

mirague commented May 22, 2017

@kratiahuja Does this cause:

FastBoot build no longer supports /Users/mirage/Projects/myproject/node_modules/ember-cli-head/app/(instance-)?initializers/browser structure. Please refer to www.ember-fastboot.com for a migration path.

I got this after upgrading from 1.0.0-beta.18 to 1.0.0-beta.19/1.0.0-rc.1.

The error message is not very helpful in that the link contains no migration support. I've reverted back to beta.18 for now.

@kratiahuja
Copy link
Contributor Author

@mirague: please see this issue #387

@kratiahuja
Copy link
Contributor Author

Test is unskipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants