-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle running in Node #21
Comments
+1 to loading everything upfront in sandbox for server side. It makes fastboot independent of app loading strategy and will probably not have a negative impact on server side rendering. |
I've updated my original comment with what I believe are the tasks needed to make this work properly. |
The pre-loading of assets poses an interesting problem, since this addon doesn't actually have any control over the build. Should this addon just assume that everything is pre-loaded? But leave the actual act of pre-loading up to the environment? I tend to think, yes. |
I tend to agree that the environment should invoke |
Won't want to do |
A path forward has been established and necessary changes have been made here. Will release version |
Could you share how exactly to configure this addon with fastboot and where the |
As far as I am aware, there is currently no way to configure this addon with Fastboot. The pieces are in place from this side, but from what I know there is no prescribed way to load additional files into the Fastboot sandbox which is what needs to be done for this to work. |
When running an Ember application in Node (such as through FastBoot), the
asset-manifest
module blows up since it can't read from the DOM (which doesn't exist).There are patterns to handle this, but it raises the overarching issue of how should lazy assets be handled within a non-browser environment.
Open questions:
My current thinking is:
In a Node process, all assets should be loaded upfront (need build targets in order to do this easily), but the manifest should still be present so that if a code path expects to load a bundle (or similar) it doesn't kill the app. This would mean that the loader functions should all return immediately resolving Promises (
Promise.resolve()
).@nathanhammond @dgeb @rwjblue would greatly appreciate hearing your thoughts on this
Tasks:
The text was updated successfully, but these errors were encountered: