diff --git a/active/0000-remove-ember-cli-eslint.md b/active/0000-remove-ember-cli-eslint.md index a66297b..5385580 100644 --- a/active/0000-remove-ember-cli-eslint.md +++ b/active/0000-remove-ember-cli-eslint.md @@ -10,6 +10,18 @@ Remove https://github.com/ember-cli/ember-cli-eslint from projects generated by designed to show lint errors during test runs. Tooling around `eslint` has improved enough where this feature may no longer be necessary. +To be clear, the proposal is _not_ to remove linting in tests. It is to follow +the rest of JavaScript community and follow the standard tooling process. + +There are multiple ways to run `eslint`: + +1. Integration with editors +2. Utilize precommit hooks with `eslint` +3. Support a standard way to run `eslint` (such as `yarn lint:js`) + +We can also discuss configuring `testem` to automatically run `eslint` as part +of `yarn test` + # Motivation 1. Improve our build speed @@ -27,11 +39,13 @@ improved enough where this feature may no longer be necessary. `devDependencies`. 2. Provide documentation on `eslint` and editor integration as well as precommit hooks - # How We Teach This -Providing documentation should suffice. Also, going towards a much more explicit -path, this should become _easier_ to teach because of less abstractions. +Providing documentation regarding how to run linting should suffice as well as +documentation to editor integration. + +Deleting abstractions and going towards a explicit path, `eslint` within the +`ember-cli` ecosystem becomes _easier_ to teach. # Drawbacks @@ -40,7 +54,7 @@ path, this should become _easier_ to teach because of less abstractions. # Alternatives -N/A +1. Leave `ember-cli-eslint` alone # Unresolved questions