ember/template-no-let-reference

[amk221]

Is it ok to disable this rule in tests? This is a contrived test case

let someThing;

hooks.beforeEach(function (assert) {
  someThing = null;
});

test('foo', async function (assert) {
  someThing = 'foo'

  await render(<template>
    <MyComponent @arg={{someThing}} />
  </template>);
});

test('bar', async function (assert) {
  someThing = 'bar'

  await render(<template>
    <MyComponent @arg={{someThing}} />
  </template>);
});

[NullVoxPopuli]

Is it ok to disable this rule in tests?

yea, I'd say so.

[NullVoxPopuli]

@bmish should we have a config for tests?

[NullVoxPopuli]

Re-opening, as this could affect many

[bmish]

I'm opposed to adding additional configs. I'd like everything to work properly with simply the recommended config. We have other rules that bail-out in test files.

[bitxplora]

The rule can be turned off in the .eslintrc.js file for the files in the test directory; if there is agreement on this, I will work on it.

Note: eslint is migrating to a new configuration format and file name.

[NullVoxPopuli]

Here is what the blueprints should probably use: #2171 (the flat config w/ eslint 9)

The rule can be turned off in the .eslintrc.js file for the files in the test directory;

yeah, we can early-return in the rule after checking the file path, then no one needs to change their eslint config

[bitxplora]

Here is what the blueprints should probably use: #2171 (the flat config w/ eslint 9)

The rule can be turned off in the .eslintrc.js file for the files in the test directory;

yeah, we can early-return in the rule after checking the file path, then no one needs to change their eslint config

If this is the rule, https://github.com/ember-cli/eslint-plugin-ember/blob/master/lib/rules/template-no-let-reference.js

We can get filepath using context.physicalFilename and return if the filepath starts with /tests/ directory.

 ... 

function checkIfWritableReferences(node, scope) {
     // Return early if the filepath starts with '/tests/' using 'context.physicalFilename`
  if (filepath.startsWith('/tests/'))  {
     return;
  }

...
}

I want to get feedback on whether the approach is appropriate.

[NullVoxPopuli]

Ye looks like a good plan

[balinterdi]

Does this have to be linted against because it creates a memory leak?