New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Babel to v6 #593

Closed

8 tasks

Gaurav0 opened this issue Apr 5, 2018 · 1 comment

Contributor

Gaurav0 commented Apr 5, 2018 •

edited by MelSumner

Loading

This is likely to be a challenging upgrade, due to the differences in the Babel transpiler in v.5 vs v.6.

Babel 5 transpiles modules using code here: https://github.com/ember-cli/ember-cli/blob/06080981a582ddefadaf16fbcbd2d3b3d397dee6/lib/models/addon.js#L1738-L1754

while Babel 6 transpiles modules using code here: https://github.com/ember-cli/ember-cli/blob/37fcddc7b75cd71ee148bee98fec603ce1516195/lib/broccoli/babel-process-modules-only.js#L18-L25

Expected steps:

1. Upgrade ember-twiddle to use Babel 6 for its own transpilation
2. Send to client Babel 6 runtime from ember-cli-build.js
3. Change how modules are compiled on client in ember-cli.js
4. Get most tests working - ensure compilation is correct.
5. Ensure addons still work even if compiled with Babel 5
6. Fix hbs plugin
7. Ensure tests still work on client (enable_testing: true).
8. Fix remaining tests.

Gaurav0 mentioned this issue

Babel upgrade #594

Merged

8 tasks

Member

acorncom commented Apr 6, 2018

@Gaurav0 does the pR above mean this issue can already be closed? 👏

Gaurav0 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment