avatar not scaled

[brianally]

Screenshot with & without overflow: hidden shows that it's pulling in a 420x420 image but not scaling it. The img tag needs w & h attrs or it could be handled in css (better, imo).

For those curious about the location bar see #214 .

[Gaurav0]

Is this only an issue in the redirect page?

[brianally]

It doesn't appear to be. In this case, the twiddle has opened inside the oauth popup, per #214, but the markup is pretty clear: the img is not being resized. It either needs width&height or the width could be set in css. The latter would allow for resizing at breakpoints.

[Gaurav0]

Unable to reproduce on http://ember-twiddle.com

[brianally]

Your avatar displays correctly? Still doing it for me. Inspect the avatar image. It does not have any dimensions but the wrapper has overflow: hidden so only the top-left corner of the image is visible.

[brianally]

ok, hold the phone! I had not set a GH avatar, so was getting the default coloured blocks. In that case, GH returns a 420x420 image. However, i've just uploaded an image(gort, as here) and GH now returns a 32x32 image.

So, the problem only manifests if a user does not have a specific avatar set. The safe thing to do, then, would be to include a style rule to explicitly size the image.

Unfortunately, there doesn't seem to be a way to undo one's avatar without overwriting it with another. If you want to see this in action i suppose you could create a dummy GH acct. and not upload an avatar. But then, you might have issues with the oauth popup if you don't delete cookies. Maybe more trouble than its worth.

In fact, if a user is getting one of those randomised avatars only the top-left 32x32 square will show, so it'll just be a light grey box. No big deal, really, as they don't have an actual avatar to display. I suggest you just close this.

[Gaurav0]

👍 Good for new contributors.