Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm should default to --ignore-scripts and --no-frozen-lockfile when installing #993

Open
NullVoxPopuli opened this issue Dec 3, 2024 · 0 comments · May be fixed by #994
Open

pnpm should default to --ignore-scripts and --no-frozen-lockfile when installing #993

NullVoxPopuli opened this issue Dec 3, 2024 · 0 comments · May be fixed by #994

Comments

@NullVoxPopuli
Copy link
Contributor

--no-frozen-lockfile or --no-lockfile, (I think already doing), obvious, we're changing deps (noted because when you set buildManagerOptions, you override)
--ignore-scripts, because folks who use prepare and use typescript will have a failing build. we do not want to re-build the addon during ember-try's install.

for example, if someone is relying on prepare behavior to build their addon:

  try-scenarios:
    timeout-minutes: 10
    name: "Try: ${{ matrix.ember-try-scenario }}"
    runs-on: ubuntu-latest

    strategy:
      # ...
    steps:
      - uses: actions/checkout@v4
      - uses: pnpm/action-setup@v4
      - uses: actions/setup-node@v4
        with:
          cache: pnpm
      # with prepare the addon builds with correct types, deps, etc
      - run: pnpm install 
      # however, today, with prepare, ember-try rebuilds it, but with incorrect dependencies (due to the ember-try config)
      # and potential repo-configurations to get around peer problems
      # such as public-hoist-pattern=ember-source
      - working-directory: test-app
        run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
@NullVoxPopuli NullVoxPopuli linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant