Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to disable beta, canary when using versionCompatability #86

Closed
ghost opened this issue Jul 27, 2016 · 3 comments
Closed

Allow user to disable beta, canary when using versionCompatability #86

ghost opened this issue Jul 27, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 27, 2016

My test suite on beta/canary right now is running into an infinite loop (due to an Ember.js bug), causing it to run for 59 minutes until Travis CI kills it.

@kategengler
Copy link
Member

Would love a PR to handle an enabled option on each scenario, for now, as a hack, you could use something like this config:

/*jshint node:true*/

module.exports = function() {
  return {
    useVersionCompatibility: true,
    scenarios: [
      {
        name: 'ember-beta',
        command: './fail.sh'
      },
      {
        name: 'ember-canary',
        command: 'echo DISABLED'
      }
    ]};
};

When the config has useVersionCompatibility: true the scenarios will merge with the auto-generated ones. Run ember try:config to see what config it will run with.

You can override the command to something harmless like echo or make a script that exits non-zero to fail the scenario.

@ghost
Copy link
Author

ghost commented Jul 28, 2016

Hey thanks! That worked and is a totally fine for a temp fix! :)

@kategengler
Copy link
Member

Closing as it should be covered by the solution to #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant