Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower version #131

Closed
jlami opened this issue Jun 13, 2017 · 1 comment
Closed

bower version #131

jlami opened this issue Jun 13, 2017 · 1 comment

Comments

@jlami
Copy link

jlami commented Jun 13, 2017

Hi,

I don't know if this is a Windows only problem. But the way you check for bower and then install it might need a little tweaking: https://github.com/ember-cli/ember-try/blob/master/lib/dependency-manager-adapters/bower.js#L194
The npm install bower@^1.3.12 should be shell escaped, or the ^ will be ignored. So npm install bower@"^1.3.12" would be better. Now version 1.3.12 is always installed.

But further more you ignore global installations of bower.
I don't know how to check for these, but maybe just checking if bower --version generates something logical? Or maybe --link with the npm install bower can help?

@kategengler
Copy link
Member

This code has been removed, in favor of adding bower implicitly to the scenarios that require it, in #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants