Restructure on disk #176
Merged
Restructure on disk #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we add support for the module unification layout the project will likely end up with two more resolvers: * addons/resolvers/module-unification * addons/resolvers/migration Pave the path for that. Additionally, drop the `create` polyfill assertion as this library only supports IE9+ where Object.create is present.
mixonic
commented
Mar 13, 2017
|
|
||
| const create = (Object.create || Ember.create); | ||
| if (!(create && !create(null).hasOwnProperty)) { | ||
| throw new Error("This browser does not support Object.create(null), please polyfil with es5-sham: http://git.io/yBU2rg"); |
There was a problem hiding this comment.
No longer needed, Object.create is present in IE9+
mixonic
commented
Mar 13, 2017
| requirejs.entries = requirejs._eak_seen; | ||
| } | ||
|
|
||
| function ModuleRegistry(entries) { |
There was a problem hiding this comment.
Moved this to be an ES class in the classic resolver. I would like to add a module-registries/ directory later when adding module unification support, but the registries in that directory should be compatible with Glimmer module registries IMO, and I'd like this non-standard one (which is only used in one place AFAICT) to not live there.
stefanpenner
approved these changes
Mar 13, 2017
| this._entries = entries || requirejs.entries; | ||
| } | ||
| moduleNames() { | ||
| return (Object.keys || Ember.keys)(this._entries); |
There was a problem hiding this comment.
I think we can safely drop Ember.keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we add support for the module unification layout the project will likely end up with two more resolvers:
Pave the path for that. Additionally, drop the
createpolyfill assertion as this library only supports IE9+ where Object.create is present.