-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlimmerWrapper: Resolve modules without a default export #189
Comments
Another way to put this is that the following lookup would occur for a specifier:
I don't actually this functionality is hard required to consider module unification support basically complete. Going to close this for now but I've bounced it off @rwjblue and @dgeb for feedback. Closing for now. |
Talked about this with @iezer. Case 2 above is used by the migrator, and we should support it. This can be done by considering the @iezer has a stab at this in the first commit of #183, but it doesn't consider |
Currently the implementation of
RequireJSRegistry
only finds default exports.We would like it to honor named exports. There are two cases where this matters.
Case 1: named exports. For example:
We expect the absolute module identifier of
ui/components/my-foo/helper
would resolve this helper.Case 2: default exports without type in the name. For example:
We expect the absolute module identifier of
ui/components/my-foo/component
would resolve this helper.The text was updated successfully, but these errors were encountered: