Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When variable and helper shares the same name, the helper always wins #108

Closed
tim-evans opened this issue Aug 20, 2015 · 5 comments
Closed

Comments

@tim-evans
Copy link
Contributor

Calling helpers should be unambiguous. If a template has a hash or positional parameter, it should call the helper, otherwise, it should lookup the variable.

See http://ember-twiddle.com/b3b796e77b72d2e6c816

Tracking issue ember-cli/ember-page-title#20

@stefanpenner
Copy link
Contributor

I'm not sure this is an ember-resolver issue, it would seem it has insufficient context to make this choice but ember proper does.

@stefanpenner
Copy link
Contributor

I suspect the change was allowing dashless helpers to be resolved at all, but that is an issue on the ember side of things (i believe).

The resolver merely provides what is asked for.

@tim-evans
Copy link
Contributor Author

That's what I thought. Should I cross post?

@stefanpenner
Copy link
Contributor

Yup

@tim-evans
Copy link
Contributor Author

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants