-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.8 fails with Cannot call method 'bind' of undefined
#3075
Comments
what version of node, npm, and what os. |
seems like an old version of sane, https://github.com/amasad/sane/blob/master/index.js does not contain a line 64. |
sorry, edited |
can you cat this file /Users/Zeppelin/tc/client/node_modules/ember-cli/node_modules/sane/index.js ? |
here you are sir: http://cl.ly/code/0K2L2u3p3d3n |
yes this is the wrong sane, and not the one I or CI seem to be installing.. |
shouldn't |
wget http://registry.npmjs.org/ember-cli/-/ember-cli-0.1.8.tgz
tar -tvf ember-cli-0.1.8.tgz | grep node_modules/sane yields 2 installations of sane, "sane": "1.0.0-rc1" |
The question remains, why the resolution algorithm is choosing the incorrect version for you.... that confuses me. |
Looks like sane is a bundled dependency and has been for a while: |
not fixed, needs more investigation |
looks like sane in broccoli-sane-watcher also needs to be updated, but i don't have time for that right now I can do that this weekend (unless someone can beet me) |
@zeppelin can you cat |
I don't even have |
sorry edited |
'use strict';
var NodeWatcher = require('./src/node_watcher');
var PollWatcher = require('./src/poll_watcher');
var WatchmanWatcher = require('./src/watchman_watcher');
function sane(dir, options) {
if (options.poll) {
return new PollWatcher(dir, options);
} else if (options.watchman) {
return new WatchmanWatcher(dir, options);
} else {
return new NodeWatcher(dir, options);
}
}
module.exports = sane;
sane.NodeWatcher = NodeWatcher;
sane.PollWatcher = PollWatcher;
sane.WatchmanWatcher = WatchmanWatcher; looks a lot like https://github.com/amasad/sane/blob/master/index.js |
@zeppelin do you have time for a quick screenshare? Would be great to know exactly what conditions trigger this. |
@zeppelin I’m [email protected] on Screenhero. Ping me if you have a moment. |
thanks a lot guys! if someone tells me again oss doesn't have proper support, I'll have him eat his hat :P |
😄 |
[fixes #3075] ensure watcher is actually new'd correctly
Both
ember server
&npm test
failsnpm: 2.2.0
node: v0.10.33
osx 10.10
ember-server
npm test
The text was updated successfully, but these errors were encountered: