Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support arbitrary unversioned blueprints (-b option in ember-cli) #546

Closed
kellyselden opened this issue Apr 5, 2019 · 3 comments
Closed

Comments

@kellyselden
Copy link
Member

kellyselden commented Apr 5, 2019

@wycats mentioned it would be nice to update https://github.com/tildeio/libkit using this tool. This would also benifit the octane blueprint before it becomes official.

The first problem is ember-cli does not support npm versions other than latest for the blueprint. ember new -b [email protected] libkit does not work. The second is, there needs to be a stored-on-disk way for a blueprint's version to be looked up in your project. One suggestion could be

// .ember-cli
{
  "ember-cli-update": {
    "blueprint": "libkit",
    "version": "0.7.0-beta.1"
  }
}

With those two problems solved, we can generate a diff between two versions of a blueprint.

@kellyselden kellyselden changed the title support arbitrary blueprints (-b option in ember-cli) support arbitrary unversioned blueprints (-b option in ember-cli) Apr 6, 2019
@gabrielgrant
Copy link

gabrielgrant commented Sep 9, 2019

Thanks a ton for working on this, it makes blueprints way more usable.

With ember-cli/ember-cli#8571 and #617 (plus its many follow-on PRs #630 #636 #643 #645 #658 #669 #671 #672 and #681 ) having landed, is this functionally complete now?

Overall, it seems like this is what you're addressing with https://github.com/kellyselden/rfcs/blob/blueprints-update/text/0477-blueprints-update.md right @kellyselden?

Are there substantial deviations/missing pieces from what's described there? The main renaming piece I'm seeing is for this to be documented, but guessing there may still be other functionality needed before you consider this release-ready?

thanks again, very eager to be able to try this out :)

@kellyselden
Copy link
Member Author

I'm still experimenting with the ideas in that RFC. That's why I haven't documented or advertised anything yet. You could probably get it to work by using --from and --blueprint together, but I would delete the resulting ember-cli-update.json because the file format is not stable yet.

@kellyselden
Copy link
Member Author

Tracked in #812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants