Skip to content
This repository has been archived by the owner on Feb 6, 2021. It is now read-only.

Plugin 1 specified in "base" provided an invalid property of "_parallelBabel" #90

Closed
kellyselden opened this issue Aug 1, 2017 · 8 comments

Comments

@kellyselden
Copy link
Member

Occurring in 1.0.

Error: Plugin 1 specified in "base" provided an invalid property of "_parallelBabel"
    at Plugin.init

Seen here:

kellyselden/package-hint-historic-resolver#435
https://travis-ci.org/kellyselden/package-hint-historic-resolver/jobs/259946508#L2824

ember-fastboot/ember-cli-fastboot#463
https://ci.appveyor.com/project/embercli/ember-cli-fastboot/build/197/job/rsjru7fvih38l8qb#L187

@rwjblue
Copy link
Member

rwjblue commented Aug 2, 2017

@mikrostew - Can you take a look?

@mikrostew
Copy link
Contributor

mikrostew commented Aug 2, 2017

Looks like #91 fixes the main error here.

But I am still seeing this warning twice when running the tests for kellyselden/package-hint-historic-resolver:

broccoli-babel-transpiler is opting out of caching due to a plugin that does not provide a caching strategy: `() => __dirname`.

I think ember-cli-babel needs to use broccoli-babel-transpiler 6.1.2, which fixes this issue as well.

@mikrostew
Copy link
Contributor

The caching error is fixed by #93.

@kellyselden - I reran the tests for package-hint-historic-resolver and that is working for me locally. I had to bump ember-cli-babel to "^6.7.1" for ember-cli-fastboot and that is working for me now as well. Does this fix the issue?

@kellyselden
Copy link
Member Author

@mikrostew
Copy link
Contributor

Ah I was reproducing this the wrong way - running npm run test was working for me, but on travis this is running code coverage, like COVERAGE=true npm run test:base, which fails.

These changes are not playing nicely with ember-cli-code-coverage. This is designed to work in the build pipeline, where the plugins are run through broccoli-babel-transpiler which converts any of this parallel stuff into the form that babel expects. But ember-cli-code-coverage is using babel outside of this, and seeing the plugin objects before they are converted.

@kellyselden
Copy link
Member Author

Ok it appears this is now just an issue with how it works with ember-cli-code-coverage.

@mikrostew So you know which project has to change to work, this or them? If them, I can close this and open an issue over there.

@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2017

We need to update ember-cli-code-coverage so that it doesn't have its own babel transpilation step.

@kellyselden
Copy link
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants