You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
It would be great to automatically run eslint using this package as a formatter, so that people can integrate their terminal with editors to easily click into a file when they see an error.
All we'd need to do is update the eslint command to add --format 'node_modules/eslint-friendly-formatter' (accounting, of course, for OS differences & npm2 vs npm3).
The text was updated successfully, but these errors were encountered:
I can see the iTerm support being useful, but wouldn't editor integration need to be done through whatever plugin is actually running the linter? For example, in Neovim I can configure Neomake to run ESLint with different arguments... You want to modify the output of ember test?
So, I got a basic version of this working and it's really simple. The problems right now are that
Formatters provided with a relative path to node_modules don't seem to be discovered correctly
The output in the test cases isn't affected; only the output before the tests cases are
It would definitely be helpful to get a better sense for what you're hoping integration with custom formatters will achieve to know if that's enough, or if you're looking for something else.
I don't know if adding a new dependency for the purpose of terminal-click is a good idea. ESLint has a unix formatter that would fit the need in terms of filenames clickability.
Now I understand that the unix formatter output is not very sexy ^^
Wouldn't adding an option to allow formatter selection be enough to begin with?
Thanks!
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It would be great to automatically run
eslint
using this package as a formatter, so that people can integrate their terminal with editors to easily click into a file when they see an error.https://github.com/royriojas/eslint-friendly-formatter
All we'd need to do is update the
eslint
command to add--format 'node_modules/eslint-friendly-formatter'
(accounting, of course, for OS differences & npm2 vs npm3).The text was updated successfully, but these errors were encountered: