Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Merge all Linting into a single test #146

Closed
vvohra opened this issue Jan 10, 2017 · 1 comment
Closed

Merge all Linting into a single test #146

vvohra opened this issue Jan 10, 2017 · 1 comment

Comments

@vvohra
Copy link

vvohra commented Jan 10, 2017

We have a large amount of files in our Ember App. Because every file is turned into a test this is causing some things some issues:

  • Majority of the log output is "ESLint - XYZ: should pass ESLint"
  • Majority of test results are also Eslint errors
  • Ember test Server becomes a pain to use because the select box is majority Eslint errors

What about having linting be one test? And the output of the test should be the files that have failed.

This might be what the ticket creator wanted #119.

@Turbo87
Copy link
Member

Turbo87 commented Jan 10, 2017

@vvohra the reason this hasn't been done is that it would impact the performance of the build in a negative way, thought I don't know how big that impact will be. I've been thinking about this in the past but the https://github.com/stefanpenner/broccoli-persistent-filter that broccoli-lint-eslint is based on only allows for 1:1 mappings of files, so this would be a rather big change, which is the reason why I haven't started that yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants